* Bug: Block agenda with tag limited clock report adds all tasks [7.5 (release_7.5.113.g9010a)]
@ 2011-03-25 3:42 Bernt Hansen
2011-04-04 20:05 ` [PATCH] Remove obsolete functionality to add todo list in front of agenda Bernt Hansen
0 siblings, 1 reply; 2+ messages in thread
From: Bernt Hansen @ 2011-03-25 3:42 UTC (permalink / raw)
To: emacs-orgmode, Carsten Dominik
Hi,
Here's another problem I noticed with block agendas and tag limited
clock reports.
This is the same setup as the previous report.
Generating a clock report including all of the clock times for today
works great. When I try to show a clock report limited to the current
tag filter with C-u R a new section is added in front of my agenda view
for "All currently open TODO items:".
Steps to reproduce:
$ minimal-emacs
| Step | Key | Details |
|------+---------+-------------------------------|
| 1 | C-c a x | Load block agenda view |
| 2 | R | Generate clock report |
| 3 | C-u R | Load tag limited clock report |
My original agenda view looks like this after step 1,
,----
| Week-agenda (W12):
| Monday 21 March 2011 W12
| Tuesday 22 March 2011
| Wednesday 23 March 2011
| Thursday 24 March 2011
| Friday 25 March 2011
| Saturday 26 March 2011
| Sunday 27 March 2011
|
| ====================================================================================================
| Tasks to Refile
`----
and after step 2 it looks like this:
,----
| Week-agenda (W12):
| Monday 21 March 2011 W12
| Tuesday 22 March 2011
| Wednesday 23 March 2011
| Thursday 24 March 2011
| Friday 25 March 2011
| Saturday 26 March 2011
| Sunday 27 March 2011
|
| | File | Headline | Time |
| |------+------------------+--------|
| | | ALL *Total time* | *0:00* |
|
| ====================================================================================================
| Tasks to Refile
`----
but after step 3 I get the following unwanted list of TODO items in
front of the agenda.
,----
| All currently open TODO items:
| org-scratch:TODO Do this
| org-scratch:TODO Do that
| org-scratch:TODO Do this other thing
| Week-agenda (W12):
| Monday 21 March 2011 W12
| Tuesday 22 March 2011
| Wednesday 23 March 2011
| Thursday 24 March 2011
| Friday 25 March 2011
| Saturday 26 March 2011
| Sunday 27 March 2011
|
| | File | Headline | Time |
| |------+------------------+--------|
| | | ALL *Total time* | *0:00* |
|
| ====================================================================================================
| Tasks to Refile
`----
The block agenda with "Tasks to Refile" is gone. I really want to keep
this block agenda view as my default agenda view.
My full block agenda view already includes all of these tasks and it
displays the details twice. The code that activates this 'All
currently open TODO items:' section seems to be related to mobile org.
~/bin/minimal-emacs
--8<---------------cut here---------------start------------->8---
#!/bin/sh
TESTEL=
TESTFILE=/tmp/test.el
if test -e $TESTFILE
then
TESTEL="-l /tmp/test.el"
fi
emacs -q -l ~/minimal.emacs $TESTEL $1
--8<---------------cut here---------------end--------------->8---
~/minimal.emacs
--8<---------------cut here---------------start------------->8---
(add-to-list 'load-path (expand-file-name "~/git/org-mode/lisp"))
(add-to-list 'auto-mode-alist '("\\.\\(org\\|org_archive\\|txt\\)$" . org-mode))
(require 'org-install)
(global-set-key "\C-cl" 'org-store-link)
(global-set-key "\C-ca" 'org-agenda)
(global-set-key "\C-cb" 'org-iswitchb)
--8<---------------cut here---------------end--------------->8---
/tmp/test.el
--8<---------------cut here---------------start------------->8---
(setq org-agenda-custom-commands (quote (("x" "Weekly Review block agenda" ((agenda "" nil) (tags "LEVEL=1+REFILE" ((org-agenda-overriding-header "Notes and Tasks to Refile") (org-agenda-todo-ignore-with-date nil) (org-agenda-todo-ignore-deadlines nil) (org-agenda-todo-ignore-scheduled nil) (org-agenda-todo-ignore-timestamp nil) (org-agenda-overriding-header "Tasks to Refile"))))))))
(setq org-agenda-files '("/tmp/publish/org-scratch.org"))
--8<---------------cut here---------------end--------------->8---
/tmp/publish/org-scratch.org
--8<---------------cut here---------------start------------->8---
* Tasks
** TODO Do this
** TODO Do that
** TODO Do this other thing
** DONE Did that
--8<---------------cut here---------------end--------------->8---
Emacs : GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0)
of 2010-12-11 on raven, modified by Debian
Package: Org-mode version 7.5 (release_7.5.113.g9010a)
Regards,
--
Bernt
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH] Remove obsolete functionality to add todo list in front of agenda
2011-03-25 3:42 Bug: Block agenda with tag limited clock report adds all tasks [7.5 (release_7.5.113.g9010a)] Bernt Hansen
@ 2011-04-04 20:05 ` Bernt Hansen
0 siblings, 0 replies; 2+ messages in thread
From: Bernt Hansen @ 2011-04-04 20:05 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Bernt Hansen
* lisp/org-agenda.el: Remove obsolete code for adding todo list in front
of the agenda
Todo lists should be built with the TODO list or a block agenda instead.
This code was triggered for C-u R in block agendas which is used to
limit the clock report to the current tags filter applied to the
agenda.
---
This patch seems to fix the problem for me but I'm not sure if it has
any other ill side-effects. I initially just did a (setq include-all
nil) but that clobbered the prefix if any for the agenda call.
Please review this before applying.
This commit is available at git://git.norang.ca/org-mode.git fix-agenda-clock-report-with-prefix
Thanks,
Bernt
lisp/org-agenda.el | 23 -----------------------
1 files changed, 0 insertions(+), 23 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 1f046f2..d7c35d1 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3457,11 +3457,6 @@ the daily/weekly agenda, see `org-agenda-skip-function'.")
The view will be for the current day or week, but from the overview buffer
you will be able to go to other days/weeks.
-With one \\[universal-argument] prefix argument INCLUDE-ALL,
-all unfinished TODO items will also be shown, before the agenda.
-This feature is considered obsolete, please use the TODO list or a block
-agenda instead.
-
With a numeric prefix argument in an interactive call, the agenda will
span INCLUDE-ALL days. Lisp programs should instead specify SPAN to change
the number of days. SPAN defaults to `org-agenda-span'.
@@ -3516,24 +3511,6 @@ given in `org-agenda-start-on-weekday'."
(org-set-local 'org-starting-day (car day-numbers))
(org-set-local 'org-include-all-loc include-all)
(org-set-local 'org-agenda-current-span (org-agenda-ndays-to-span span))
- (when (and (or include-all org-agenda-include-all-todo)
- (member today day-numbers))
- (setq files thefiles
- rtnall nil)
- (while (setq file (pop files))
- (catch 'nextfile
- (org-check-agenda-file file)
- (setq date (calendar-gregorian-from-absolute today)
- rtn (org-agenda-get-day-entries
- file date :todo))
- (setq rtnall (append rtnall rtn))))
- (when rtnall
- (insert "All currently open TODO items:\n")
- (add-text-properties (point-min) (1- (point))
- (list 'face 'org-agenda-structure
- 'short-heading "All TODO items"))
- (org-agenda-mark-header-line (point-min))
- (insert (org-finalize-agenda-entries rtnall) "\n")))
(unless org-agenda-compact-blocks
(let* ((d1 (car day-numbers))
(d2 (org-last day-numbers))
--
1.7.5.rc0.100.gcb35c0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-04 20:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-25 3:42 Bug: Block agenda with tag limited clock report adds all tasks [7.5 (release_7.5.113.g9010a)] Bernt Hansen
2011-04-04 20:05 ` [PATCH] Remove obsolete functionality to add todo list in front of agenda Bernt Hansen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).