From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: [PATCH] Remove obsolete functionality to add todo list in front of agenda Date: Mon, 4 Apr 2011 16:05:43 -0400 Message-ID: <1301947543-6195-1-git-send-email-bernt@norang.ca> References: <87pqpfooh0.fsf@norang.ca> Return-path: Received: from [140.186.70.92] (port=55899 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6q2O-0007xj-4d for emacs-orgmode@gnu.org; Mon, 04 Apr 2011 16:06:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6q2M-0006Hr-Rg for emacs-orgmode@gnu.org; Mon, 04 Apr 2011 16:06:12 -0400 Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:33110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6q2M-0006Hl-OD for emacs-orgmode@gnu.org; Mon, 04 Apr 2011 16:06:10 -0400 Received: from cpe000102d0fe75-cm0012256ecbde.cpe.net.cable.rogers.com ([99.239.148.180] helo=mail.norang.ca) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1Q6pjU-0009wD-94 for emacs-orgmode@gnu.org; Mon, 04 Apr 2011 19:46:40 +0000 In-Reply-To: <87pqpfooh0.fsf@norang.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Cc: Bernt Hansen * lisp/org-agenda.el: Remove obsolete code for adding todo list in front of the agenda Todo lists should be built with the TODO list or a block agenda instead. This code was triggered for C-u R in block agendas which is used to limit the clock report to the current tags filter applied to the agenda. --- This patch seems to fix the problem for me but I'm not sure if it has any other ill side-effects. I initially just did a (setq include-all nil) but that clobbered the prefix if any for the agenda call. Please review this before applying. This commit is available at git://git.norang.ca/org-mode.git fix-agenda-clock-report-with-prefix Thanks, Bernt lisp/org-agenda.el | 23 ----------------------- 1 files changed, 0 insertions(+), 23 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 1f046f2..d7c35d1 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -3457,11 +3457,6 @@ the daily/weekly agenda, see `org-agenda-skip-function'.") The view will be for the current day or week, but from the overview buffer you will be able to go to other days/weeks. -With one \\[universal-argument] prefix argument INCLUDE-ALL, -all unfinished TODO items will also be shown, before the agenda. -This feature is considered obsolete, please use the TODO list or a block -agenda instead. - With a numeric prefix argument in an interactive call, the agenda will span INCLUDE-ALL days. Lisp programs should instead specify SPAN to change the number of days. SPAN defaults to `org-agenda-span'. @@ -3516,24 +3511,6 @@ given in `org-agenda-start-on-weekday'." (org-set-local 'org-starting-day (car day-numbers)) (org-set-local 'org-include-all-loc include-all) (org-set-local 'org-agenda-current-span (org-agenda-ndays-to-span span)) - (when (and (or include-all org-agenda-include-all-todo) - (member today day-numbers)) - (setq files thefiles - rtnall nil) - (while (setq file (pop files)) - (catch 'nextfile - (org-check-agenda-file file) - (setq date (calendar-gregorian-from-absolute today) - rtn (org-agenda-get-day-entries - file date :todo)) - (setq rtnall (append rtnall rtn)))) - (when rtnall - (insert "All currently open TODO items:\n") - (add-text-properties (point-min) (1- (point)) - (list 'face 'org-agenda-structure - 'short-heading "All TODO items")) - (org-agenda-mark-header-line (point-min)) - (insert (org-finalize-agenda-entries rtnall) "\n"))) (unless org-agenda-compact-blocks (let* ((d1 (car day-numbers)) (d2 (org-last day-numbers)) -- 1.7.5.rc0.100.gcb35c0