From: Bernt Hansen <bernt@norang.ca>
To: emacs-orgmode@gnu.org
Cc: Bernt Hansen <bernt@norang.ca>
Subject: [PATCH] Remove obsolete functionality to add todo list in front of agenda
Date: Mon, 4 Apr 2011 16:05:43 -0400 [thread overview]
Message-ID: <1301947543-6195-1-git-send-email-bernt@norang.ca> (raw)
In-Reply-To: <87pqpfooh0.fsf@norang.ca>
* lisp/org-agenda.el: Remove obsolete code for adding todo list in front
of the agenda
Todo lists should be built with the TODO list or a block agenda instead.
This code was triggered for C-u R in block agendas which is used to
limit the clock report to the current tags filter applied to the
agenda.
---
This patch seems to fix the problem for me but I'm not sure if it has
any other ill side-effects. I initially just did a (setq include-all
nil) but that clobbered the prefix if any for the agenda call.
Please review this before applying.
This commit is available at git://git.norang.ca/org-mode.git fix-agenda-clock-report-with-prefix
Thanks,
Bernt
lisp/org-agenda.el | 23 -----------------------
1 files changed, 0 insertions(+), 23 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 1f046f2..d7c35d1 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3457,11 +3457,6 @@ the daily/weekly agenda, see `org-agenda-skip-function'.")
The view will be for the current day or week, but from the overview buffer
you will be able to go to other days/weeks.
-With one \\[universal-argument] prefix argument INCLUDE-ALL,
-all unfinished TODO items will also be shown, before the agenda.
-This feature is considered obsolete, please use the TODO list or a block
-agenda instead.
-
With a numeric prefix argument in an interactive call, the agenda will
span INCLUDE-ALL days. Lisp programs should instead specify SPAN to change
the number of days. SPAN defaults to `org-agenda-span'.
@@ -3516,24 +3511,6 @@ given in `org-agenda-start-on-weekday'."
(org-set-local 'org-starting-day (car day-numbers))
(org-set-local 'org-include-all-loc include-all)
(org-set-local 'org-agenda-current-span (org-agenda-ndays-to-span span))
- (when (and (or include-all org-agenda-include-all-todo)
- (member today day-numbers))
- (setq files thefiles
- rtnall nil)
- (while (setq file (pop files))
- (catch 'nextfile
- (org-check-agenda-file file)
- (setq date (calendar-gregorian-from-absolute today)
- rtn (org-agenda-get-day-entries
- file date :todo))
- (setq rtnall (append rtnall rtn))))
- (when rtnall
- (insert "All currently open TODO items:\n")
- (add-text-properties (point-min) (1- (point))
- (list 'face 'org-agenda-structure
- 'short-heading "All TODO items"))
- (org-agenda-mark-header-line (point-min))
- (insert (org-finalize-agenda-entries rtnall) "\n")))
(unless org-agenda-compact-blocks
(let* ((d1 (car day-numbers))
(d2 (org-last day-numbers))
--
1.7.5.rc0.100.gcb35c0
prev parent reply other threads:[~2011-04-04 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 3:42 Bug: Block agenda with tag limited clock report adds all tasks [7.5 (release_7.5.113.g9010a)] Bernt Hansen
2011-04-04 20:05 ` Bernt Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301947543-6195-1-git-send-email-bernt@norang.ca \
--to=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).