* [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function
@ 2019-09-29 0:54 Anton Latukha
2019-10-08 9:15 ` Nicolas Goaziou
0 siblings, 1 reply; 3+ messages in thread
From: Anton Latukha @ 2019-09-29 0:54 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/html, Size: 181 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-org-get-priority-function-doc-add-that-it-holds-.patch --]
[-- Type: text/x-diff; name="0001-org-org-get-priority-function-doc-add-that-it-holds-.patch", Size: 1015 bytes --]
From da3066489128af42a89e498db7fb8b0bcda9e431 Mon Sep 17 00:00:00 2001
From: Anton-Latukha <anton.latukha@gmail.com>
Date: Sun, 29 Sep 2019 03:41:17 +0300
Subject: [PATCH] org: org-get-priority-function: doc: add that it holds a func
name
* org (org-get-priority-function): Make clear that *this must hold the
name of a custom priority getter function (there were cases of
confusion).
---
lisp/org.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org.el b/lisp/org.el
index 450d16083..113d97a8f 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -2591,7 +2591,7 @@ See also `org-default-priority'."
:type 'boolean)
(defcustom org-get-priority-function nil
- "Function to extract the priority from a string.
+ "Name of a function to extract the priority from a string.
The string is normally the headline. If this is nil Org computes the
priority from the priority cookie like [#A] in the headline. It returns
an integer, increasing by 1000 for each priority level.
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function
2019-09-29 0:54 [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function Anton Latukha
@ 2019-10-08 9:15 ` Nicolas Goaziou
2019-10-08 12:32 ` Anton Latukha
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2019-10-08 9:15 UTC (permalink / raw)
To: Anton Latukha; +Cc: emacs-orgmode
Hello,
Anton Latukha <anton@latukha.com> writes:
> Additionally state that this is a holder of a function name, so the
> simple user did not get confused.
Your patch doesn't sound right. The value could be a lambda function, or
a symbol with a function value. Besides, "function name" is confusing.
It could mean, e.g., a string.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function
2019-10-08 9:15 ` Nicolas Goaziou
@ 2019-10-08 12:32 ` Anton Latukha
0 siblings, 0 replies; 3+ messages in thread
From: Anton Latukha @ 2019-10-08 12:32 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/html, Size: 779 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-08 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-29 0:54 [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function Anton Latukha
2019-10-08 9:15 ` Nicolas Goaziou
2019-10-08 12:32 ` Anton Latukha
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).