emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: Subject: [PATCH] Fix DISPLAY error on exporting org with plantuml to html
Date: Tue, 7 Jun 2022 21:49:29 +0700	[thread overview]
Message-ID: <t7nohq$l7u$1@ciao.gmane.io> (raw)
In-Reply-To: <87a6ap2d67.fsf@web.de>

On 07/06/2022 13:34, Dr. Arne Babenhauserheide wrote:
> 
> lin Sun writes:
>> This patch will re-submit the solution based on the last rev.

>> diff --git a/lisp/ob-plantuml.el b/lisp/ob-plantuml.el
>> index 6e1b1b1..37a631b 100644
>> --- a/lisp/ob-plantuml.el
>> +++ b/lisp/ob-plantuml.el
>> @@ -122,6 +122,7 @@ This function is called by `org-babel-execute-src-block'."
>>   				((not (file-exists-p org-plantuml-jar-path))
>>   				 (error "Could not find plantuml.jar at %s" org-plantuml-jar-path))
>>   				(t `(,java
>> +                                     "-Djava.awt.headless=true"
> 
> This looks good and low-risk to me.

Could you, please, clarify why -headless in `org-plantuml-args' is not 
enough and -Djava.awt.headless=true should be added despite it looks 
redundant. Another question is why this option should be applied to jar 
but not to plantuml launcher script. The commit dropping this option has 
a link to discussion whether this argument is necessary and hard coded 
in such way.

> 
>>   				     "-jar"
>>   				     ,(shell-quote-argument (expand-file-name org-plantuml-jar-path))
>>                                        ,@org-plantuml-args))))



  reply	other threads:[~2022-06-07 14:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <388850760.3644614.1634354740816.ref@mail.yahoo.com>
2021-10-16  3:25 ` Subject: [PATCH] Fix DISPLAY error on exporting org with plantuml to html Sun Lin
2021-10-18  1:39   ` Sun Lin
2021-10-18  5:07     ` Bastien Guerry
2021-10-20 12:02       ` Sun Lin
2021-11-18  5:42         ` Sun Lin
2021-11-18  7:38   ` Timothy
2021-11-18  7:47     ` Sun Lin
2021-11-30  1:41       ` Sun Lin
2021-11-30  4:18         ` Timothy
2021-11-30  6:05           ` Sun Lin
2022-06-07  5:48             ` lin Sun via General discussions about Org-mode.
2022-06-07  6:34               ` Dr. Arne Babenhauserheide
2022-06-07 14:49                 ` Max Nikulin [this message]
2022-06-07 15:30                 ` lin Sun
2022-06-08  1:45               ` Ihor Radchenko
2022-06-08  4:35                 ` lin Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='t7nohq$l7u$1@ciao.gmane.io' \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).