emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Timothy <tecosaur@gmail.com>
To: Sun Lin <sunlin7@yahoo.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Subject: [PATCH] Fix DISPLAY error on exporting org with plantuml to html
Date: Thu, 18 Nov 2021 15:38:39 +0800	[thread overview]
Message-ID: <87k0h5gbad.fsf@gmail.com> (raw)
In-Reply-To: <388850760.3644614.1634354740816@mail.yahoo.com>


Hi Sun,

> [snipped patch description]
> Please help review the patch. Thanks.
> [2. text/x-patch; 0001-Fix-DISPLAY-error-on-exporting-org-with-plantuml-to-.patch]...

Thanks for your patience. This looks quite straight-forward. I don't use
or have plantuml so I'm in a poor position to test.

However, I can use google, and it seems that -Djava.awt.headless=true
just uses Java for some graphics operations which are normally delegated
to the system graphics stack.

This seems rather safe to me, and so I'd be inclined to take your word
that this is a beneficial change and merge the patch.

All the best,
Timothy


  parent reply	other threads:[~2021-11-18  7:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <388850760.3644614.1634354740816.ref@mail.yahoo.com>
2021-10-16  3:25 ` Subject: [PATCH] Fix DISPLAY error on exporting org with plantuml to html Sun Lin
2021-10-18  1:39   ` Sun Lin
2021-10-18  5:07     ` Bastien Guerry
2021-10-20 12:02       ` Sun Lin
2021-11-18  5:42         ` Sun Lin
2021-11-18  7:38   ` Timothy [this message]
2021-11-18  7:47     ` Sun Lin
2021-11-30  1:41       ` Sun Lin
2021-11-30  4:18         ` Timothy
2021-11-30  6:05           ` Sun Lin
2022-06-07  5:48             ` lin Sun via General discussions about Org-mode.
2022-06-07  6:34               ` Dr. Arne Babenhauserheide
2022-06-07 14:49                 ` Max Nikulin
2022-06-07 15:30                 ` lin Sun
2022-06-08  1:45               ` Ihor Radchenko
2022-06-08  4:35                 ` lin Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0h5gbad.fsf@gmail.com \
    --to=tecosaur@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=sunlin7@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).