emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ruijie Yu via "General discussions about Org-mode." <emacs-orgmode@gnu.org>
To: lin Sun <sunlin7@yahoo.com>
Cc: Timothy <tecosaur@gmail.com>, Bastien Guerry <bzg@gnu.org>,
Subject: Re: [PATCH] before emit an error message, try to load the babel language
Date: Sat, 22 Apr 2023 16:25:29 +0800	[thread overview]
Message-ID: <sdva5z0wc38.fsf@netyu.xyz> (raw)
In-Reply-To: <CABCREdr+XevsNnc1YsiHubXS=QO28-SHEhRLFnwxntKo-XOZcw@mail.gmail.com>

lin Sun <sunlin7@yahoo.com> writes:

> Hi,
> The function `org-babel-execute-src-block' will emit an error message
> if the language is not loaded.
> Before the error message, the patch will give a try to load the
> associated babel language.
> Why does the language exist in the `lang org-babel-load-languages' but
> not be loaded?
> Because the `org-babel-load-languages' are defined as a customer
> variable with  :set 'org-babel-do-load-languages,  the ":set" function
> can only be triggered with function `custom-set-variables`.
> While setq/cl-pushnew `org-babel-load-languages' won't trigger the
> `:set' function, then the error message will be displayed if I run the
> code in the org file.
> Please help review that patch. Thanks. Regards
> [2. text/x-patch; 0001-lisp-ob-core.el-load-lang-in-org-babel-execute-src-b.patch]...

I think this patch slightly modifies the logic of the error.

--8<---------------cut here---------------start------------->8---
 	    (unless (fboundp cmd)
-	      (error "No org-babel-execute function for %s!" lang))
+              (if (alist-get lang org-babel-load-languages)
+                  (require (intern (concat "ob-" lang)))
+                (error "No org-babel-execute function for %s!" lang)))
--8<---------------cut here---------------end--------------->8---

You are saying, that when (fboundp cmd) returns nil, and when (alist-get
...) returns non-nil, then perform the `require', and assume this
function is now available.

Instead of that, I think you should have some sort of conditional in the
`unless' condition.  Something like:

--8<---------------cut here---------------start------------->8---
(unless (or (fboundp cmd)
            (ignore (and (alist-get lang org-babel-load-languages)
                         (require (intern (concat "ob-" lang)))))
            (fboundp cmd))
  (error "... %s" lang))
--8<---------------cut here---------------end--------------->8---

This preserves the logic of the message: when we cannot get
"org-babel-execute" immediately, we then try to require the module and
try again.  Then, we check the function again and conclude that the
org-babel-execute function is not found for this language.




[Please note that this mail might go to spam due to some
misconfiguration in my mail server -- still investigating.]

  reply	other threads:[~2023-04-22  8:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <388850760.3644614.1634354740816.ref@mail.yahoo.com>
2021-10-16  3:25 ` Subject: [PATCH] Fix DISPLAY error on exporting org with plantuml to html Sun Lin
2021-10-18  1:39   ` Sun Lin
2021-10-18  5:07     ` Bastien Guerry
2021-10-20 12:02       ` Sun Lin
2021-11-18  5:42         ` Sun Lin
2021-11-18  7:38   ` Timothy
2021-11-18  7:47     ` Sun Lin
2021-11-30  1:41       ` Sun Lin
2021-11-30  4:18         ` Timothy
2021-11-30  6:05           ` Sun Lin
2022-06-07  5:48             ` lin Sun via General discussions about Org-mode.
2022-06-07  6:34               ` Dr. Arne Babenhauserheide
2022-06-07 14:49                 ` Max Nikulin
2022-06-07 15:30                 ` lin Sun
2022-06-08  1:45               ` Ihor Radchenko
2022-06-08  4:35                 ` lin Sun
2023-04-22  7:21                   ` [PATCH] before emit an error message, try to load the babel language lin Sun
2023-04-22  8:25                     ` Ruijie Yu via General discussions about Org-mode. [this message]
2023-04-22 12:45                     ` Ihor Radchenko
2023-04-23  6:19                       ` lin Sun
2023-04-23  7:45                         ` Ihor Radchenko
2023-04-25  2:50                           ` lin Sun
2023-04-25  8:12                             ` Ihor Radchenko
2023-04-25 14:30                               ` Ruijie Yu via General discussions about Org-mode.
2023-04-25 14:48                                 ` Ihor Radchenko
2023-04-26  2:33                                   ` Ruijie Yu via General discussions about Org-mode.
2023-04-26  4:15                                     ` lin Sun
2023-04-26  7:00                                       ` Ihor Radchenko
2023-04-26 16:43                                         ` lin Sun
2023-04-26 16:59                                           ` Ihor Radchenko
2023-04-26  6:59                                     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sdva5z0wc38.fsf@netyu.xyz \
    --to=emacs-orgmode@gnu.org \
    --cc=bzg@gnu.org \
    --cc=ruijie@netyu.xyz \
    --cc=sunlin7@yahoo.com \
    --cc=tecosaur@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).