From: Max Nikulin <firstname.lastname@example.org>
Subject: Re: [PATCH] Fix regex for determining image width from attribute
Date: Mon, 29 Nov 2021 19:15:27 +0700 [thread overview]
Message-ID: <email@example.com> (raw)
On 29/11/2021 07:23, Matt Huszagh wrote:
> Max Nikulin writes:
>> My current variant:
>> The regexp should not match e.g.
>> #+attr_html: :alt something
>> :width 600
>> P.S. I would prefer to use the same parser as ox does.
> I can probably implement this if people want. But, let me know if I
> should indeed use org-export-registered-backends. However, I'm starting
> to feel like this should be separate patch (the goal for mine was just
> to prioritize attr_org).
I am against regexps that have obvious flaws. I admit however that the
regexp that appeared long time ago before your patch fails for some
corner cases as well.
I will left decision to you and to Org developers and maintainers.
Additionally, I like that Timothy transformed a code fragment into
`org-display-inline-image--width' function and, I suppose, it deserves
some unit tests (see testing/README file).
next prev parent reply other threads:[~2021-11-29 12:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 19:08 [PATCH] Fix regex for determining image width from attribute Matt Huszagh
2021-11-21 19:20 ` Timothy
2021-11-21 19:51 ` Matt Huszagh
2021-11-22 8:29 ` Timothy
2021-11-22 16:11 ` Matt Huszagh
2021-11-22 17:54 ` Timothy
2021-11-22 20:53 ` Matt Huszagh
2021-11-23 4:59 ` Kyle Meyer
2021-11-23 5:14 ` Timothy
2021-11-23 5:38 ` Matt Huszagh
2021-11-23 5:39 ` Timothy
2021-11-23 7:46 ` Matt Huszagh
2021-11-23 16:44 ` Max Nikulin
2021-11-24 1:57 ` Matt Huszagh
2021-11-24 14:48 ` Max Nikulin
2021-11-24 15:59 ` Matt Huszagh
2021-11-24 17:00 ` Max Nikulin
2021-11-25 16:43 ` Max Nikulin
2021-11-29 0:23 ` Matt Huszagh
2021-11-29 5:13 ` Timothy
2021-12-01 3:24 ` Matt Huszagh
2021-12-01 4:54 ` Timothy
2021-12-03 2:06 ` Matt Huszagh
2021-11-29 12:15 ` Max Nikulin [this message]
2021-11-22 14:30 ` Max Nikulin
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).