From: Kyle Meyer <firstname.lastname@example.org> To: Matt Huszagh <email@example.com> Cc: firstname.lastname@example.org, Timothy <email@example.com> Subject: Re: [PATCH] Fix regex for determining image width from attribute Date: Mon, 22 Nov 2021 23:59:42 -0500 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> Matt Huszagh writes: > Timothy <firstname.lastname@example.org> writes: > >> I’ve just pushed the change I described in 4514a32. This improves the >> interpretation of :width attributes and makes a value of “t” work as discussed. >> I have not prioritised #+attr_org for now, but that sounds like a change we >> could make in the future. > > Thanks Timothy. However, I think this change may have some issues. It > seems that it unbalances parentheses. This also no longer sets width > (so, e.g., (floatp width) won't work). Maybe attr-width was intended to > be renamed to width? Are you seeing the same? I'm not sure either, but this syntax error brings down the whole tree, so I've pushed 27f26f782 to resolve it. Timothy, please check my guess at what the intended code was.
next prev parent reply other threads:[~2021-11-23 5:00 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-21 19:08 Matt Huszagh 2021-11-21 19:20 ` Timothy 2021-11-21 19:51 ` Matt Huszagh 2021-11-22 8:29 ` Timothy 2021-11-22 16:11 ` Matt Huszagh 2021-11-22 17:54 ` Timothy 2021-11-22 20:53 ` Matt Huszagh 2021-11-23 4:59 ` Kyle Meyer [this message] 2021-11-23 5:14 ` Timothy 2021-11-23 5:38 ` Matt Huszagh 2021-11-23 5:39 ` Timothy 2021-11-23 7:46 ` Matt Huszagh 2021-11-23 16:44 ` Max Nikulin 2021-11-24 1:57 ` Matt Huszagh 2021-11-24 14:48 ` Max Nikulin 2021-11-24 15:59 ` Matt Huszagh 2021-11-24 17:00 ` Max Nikulin 2021-11-25 16:43 ` Max Nikulin 2021-11-29 0:23 ` Matt Huszagh 2021-11-29 5:13 ` Timothy 2021-12-01 3:24 ` Matt Huszagh 2021-12-01 4:54 ` Timothy 2021-12-03 2:06 ` Matt Huszagh 2021-11-29 12:15 ` Max Nikulin 2021-11-22 14:30 ` Max Nikulin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] Fix regex for determining image width from attribute' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).