From: Max Nikulin <firstname.lastname@example.org> To: email@example.com Subject: Re: [PATCH] Fix regex for determining image width from attribute Date: Wed, 24 Nov 2021 21:48:42 +0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On 24/11/2021 08:57, Matt Huszagh wrote: > Max Nikulin writes: > >> I may be wrong, but it seems both the old and the new regexps match >> >> #+attr_html : :width 50% >> >> that is not a keyword due to a space before ":". The dot in the regexp >> is too permissive. > > I agree. > >> Despite ".*" includes ": " before ":width", I would prefer explicit >> space before ":width". > > Currently we have a space before .*. Would you prefer it after? Anyway, > I've also implemented this change. Let me know what you think. This is related solely to docscring. > +that is not found, use the first #+ATTR_.*:width specification. I am unsure how to make this phrase more clear, maybe something like "use :width value from the first #+ATTR_,*" or even "#+ATTR_xxx" to avoid ".*". > + (re-search-forward (funcall attr-re "[a-z]*?") > + par-end t)))) https://orgmode.org/worg/dev/org-syntax.html#Keywords has no requirement that it may be letter only. I expect it to be more coherent with http://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/org-element.el#n2387 that uses "\\S-" non-space character.
next prev parent reply other threads:[~2021-11-24 14:49 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-21 19:08 Matt Huszagh 2021-11-21 19:20 ` Timothy 2021-11-21 19:51 ` Matt Huszagh 2021-11-22 8:29 ` Timothy 2021-11-22 16:11 ` Matt Huszagh 2021-11-22 17:54 ` Timothy 2021-11-22 20:53 ` Matt Huszagh 2021-11-23 4:59 ` Kyle Meyer 2021-11-23 5:14 ` Timothy 2021-11-23 5:38 ` Matt Huszagh 2021-11-23 5:39 ` Timothy 2021-11-23 7:46 ` Matt Huszagh 2021-11-23 16:44 ` Max Nikulin 2021-11-24 1:57 ` Matt Huszagh 2021-11-24 14:48 ` Max Nikulin [this message] 2021-11-24 15:59 ` Matt Huszagh 2021-11-24 17:00 ` Max Nikulin 2021-11-25 16:43 ` Max Nikulin 2021-11-29 0:23 ` Matt Huszagh 2021-11-29 5:13 ` Timothy 2021-12-01 3:24 ` Matt Huszagh 2021-12-01 4:54 ` Timothy 2021-12-03 2:06 ` Matt Huszagh 2021-11-29 12:15 ` Max Nikulin 2021-11-22 14:30 ` Max Nikulin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org' \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] Fix regex for determining image width from attribute' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).