From: Maxim Nikulin <firstname.lastname@example.org> To: email@example.com Subject: Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use Date: Wed, 2 Jun 2021 23:44:14 +0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On 02/06/2021 22:08, Utkarsh Singh wrote: > ;;;###autoload > (defun org-table-import (file separator) > @@ -955,12 +971,13 @@ lines. It can have the following values: > - integer When a number, use that many spaces, or a TAB, as field separator. > - regexp When a regular expression, use it to match the separator." > (interactive (list (read-file-name "Import file: ") > - (prefix-numeric-value current-prefix-arg))) > + current-prefix-arg)) It seems, prefix argument works now. Let me remind that file name completion was working better before your change. I have noticed a couple of error messages. Unsure what is going wrong, I hope, command to launch emacs is correct (-Q -L ~/src/org-mode/lisp test.org). At startup: Eager macro-expansion failure: (error "rx ‘not’ syntax error: (or 10 44)") In response to M-x org-table-import: rx-check-not: rx ‘not’ syntax error: (or 10 44) > Currently I am trying to refactor CSV parsing by applying techniques > used in pcsv library (MELPA package) which I think you will also enjoy > to play with! I do not know opinion of Org maintainers. Personally I believe that org can take advantage of Emacs core features or of other packages if they are available and fallback to minimal implementation otherwise. Unsure whether borrowing code from pcsv can cause license issues. Current CSV parser is not perfect but it works reasonably well.
next prev parent reply other threads:[~2021-06-02 16:44 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-19 4:43 Utkarsh Singh 2021-04-19 8:19 ` Nicolas Goaziou 2021-04-19 14:23 ` Utkarsh Singh 2021-04-20 13:40 ` Nicolas Goaziou 2021-04-20 17:15 ` Utkarsh Singh 2021-04-23 4:58 ` Utkarsh Singh 2021-04-27 20:21 ` bug#47885: " Nicolas Goaziou 2021-04-28 8:37 ` Utkarsh Singh 2021-04-28 16:38 ` Maxim Nikulin 2021-05-10 18:36 ` Utkarsh Singh 2021-05-12 17:08 ` Maxim Nikulin 2021-05-14 14:54 ` Utkarsh Singh 2021-05-15 9:13 ` Bastien 2021-05-15 10:10 ` Utkarsh Singh 2021-05-15 10:30 ` Bastien 2021-05-15 11:09 ` Utkarsh Singh 2021-05-17 5:29 ` Bastien 2021-05-17 16:27 ` Utkarsh Singh 2021-06-01 16:23 ` Maxim Nikulin 2021-06-01 17:46 ` Utkarsh Singh 2021-06-02 12:06 ` Maxim Nikulin 2021-06-02 15:08 ` Utkarsh Singh 2021-06-02 16:44 ` Maxim Nikulin [this message] 2021-06-04 4:04 ` Utkarsh Singh 2021-06-05 12:40 ` Maxim Nikulin 2021-06-05 17:50 ` Utkarsh Singh 2021-06-09 12:15 ` Maxim Nikulin 2021-09-26 8:40 ` Bastien 2021-05-16 16:24 ` Maxim Nikulin 2021-05-17 16:30 ` Utkarsh Singh 2021-05-18 10:24 ` Utkarsh Singh 2021-05-18 12:31 ` Maxim Nikulin 2021-05-18 15:05 ` Utkarsh Singh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org' \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).