From: Utkarsh Singh <utkarsh190601@gmail.com> To: Nicolas Goaziou <mail@nicolasgoaziou.fr> Cc: 47885@debbugs.gnu.org, emacs-orgmode@gnu.org Subject: Re: [PATCH] org-table-import: Make it more smarter for interactive use Date: Tue, 20 Apr 2021 22:45:22 +0530 [thread overview] Message-ID: <87r1j4ri6t.fsf@gmail.com> (raw) In-Reply-To: <87im4h9irn.fsf@nicolasgoaziou.fr> Hi, On 2021-04-20, 15:40 +0200, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote: > For the problem we're trying to solve, this sounds like over-engineering > to me. Do we want so badly to guess a separator? Earlier I took is as an assignment to learn Elisp but now I don't think we should increase complexity this much. > Thinking again about it, this needs extra care, as end0 might end up on > an empty line. You tried to avoid this in your first function, but > I think this was not sufficient either. Actually, beg0 could also start > on an empty line. > > This needs to be tested extensively, but as a first approximation, > I think `beg' needs to be defined as: > > (save-excursion > (goto-char (min beg0 end0)) > (skip-chars-forward " \t\n") > (if (eobp) (point) (line-beginning-position))) > > and `end' as > > (save-excursion > (goto-char (max beg end0)) > (skip-chars-backward " \t\n" beg) > (if (= beg (point)) (point) (line-end-position))) > > Then you need to bail out if beg = end. > >> (sep-rexp '(("," "^[^\n,]+$") > > sep-rexp -> sep-regexp > >> ("\t" "^[^\n\t]+$") >> (";" "^[^\n;]+$") >> (":" "^[^\n:]+$") >> (" " "^\\([^'\"][^\n\s][^'\"]\\)+$"))) > > At this point, I suggest to use `rx' macro instead. > > I suggest this (yes, I like pattern-matching, `car' and `cdr' are so > 80's) instead: > > (save-excursion > (goto-char beg) > (catch :found > (pcase-dolist (`(,sep ,regexp) sep-regexp) > (save-excursion > (unless (re-search-forward regexp end t) > (throw :found sep)))) > nil)) > Thanks! I was not aware of pcase-dolist function. Function after doing the necessary changes: (defun org-table-guess-separator (beg0 end0) "Guess separator for `org-table-convert-region' for region BEG0 to END0. List of preferred separator: comma, TAB, semicolon, colon or SPACE. If region contains a line which doesn't contain the required separator then discard the separator and search again using next separator." (let* ((beg (save-excursion (goto-char (min beg0 end0)) (skip-chars-forward " \t\n") (if (eobp) (point) (line-beginning-position)))) (end (save-excursion (goto-char (max beg end0)) (skip-chars-backward " \t\n" beg) (if (= beg (point)) (point) (line-end-position)))) (sep-regexp '(("," (rx bol (1+ (not (or ?\n ?,))) eol)) ("\t" (rx bol (1+ (not (or ?\n ?\t))) eol)) (";" (rx bol (1+ (not (or ?\n ?\;))) eol)) (":" (rx bol (1+ (not (or ?\n ?:))) eol)) (" " (rx bol (1+ (not (or ?' ?\" )) (not (or ?\s ?\;)) (not (or ?' ?\"))) eol)))) sep) (unless (= beg end) (save-excursion (goto-char beg) (catch :found (pcase-dolist (`(,sep ,regexp) sep-regexp) (save-excursion (unless (re-search-forward (eval regexp) end t) (throw :found sep)))) nil))))) > Again all this needs to extensively tested, as there are a lot of > dangers lurking around. Summary of things that still requires a review: + Setting boundary right + When using SPACE as separator is it sufficient to check for all for all non quoted SPACE's? -- Utkarsh Singh http://utkarshsingh.xyz
next prev parent reply other threads:[~2021-04-20 17:17 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-19 4:43 Utkarsh Singh 2021-04-19 8:19 ` Nicolas Goaziou 2021-04-19 14:23 ` Utkarsh Singh 2021-04-20 13:40 ` Nicolas Goaziou 2021-04-20 17:15 ` Utkarsh Singh [this message] 2021-04-23 4:58 ` Utkarsh Singh 2021-04-27 20:21 ` bug#47885: " Nicolas Goaziou 2021-04-28 8:37 ` Utkarsh Singh 2021-04-28 16:38 ` Maxim Nikulin 2021-05-10 18:36 ` Utkarsh Singh 2021-05-12 17:08 ` Maxim Nikulin 2021-05-14 14:54 ` Utkarsh Singh 2021-05-15 9:13 ` Bastien 2021-05-15 10:10 ` Utkarsh Singh 2021-05-15 10:30 ` Bastien 2021-05-15 11:09 ` Utkarsh Singh 2021-05-17 5:29 ` Bastien 2021-05-17 16:27 ` Utkarsh Singh 2021-06-01 16:23 ` Maxim Nikulin 2021-06-01 17:46 ` Utkarsh Singh 2021-06-02 12:06 ` Maxim Nikulin 2021-06-02 15:08 ` Utkarsh Singh 2021-06-02 16:44 ` Maxim Nikulin 2021-06-04 4:04 ` Utkarsh Singh 2021-06-05 12:40 ` Maxim Nikulin 2021-06-05 17:50 ` Utkarsh Singh 2021-06-09 12:15 ` Maxim Nikulin 2021-09-26 8:40 ` Bastien 2021-05-16 16:24 ` Maxim Nikulin 2021-05-17 16:30 ` Utkarsh Singh 2021-05-18 10:24 ` Utkarsh Singh 2021-05-18 12:31 ` Maxim Nikulin 2021-05-18 15:05 ` Utkarsh Singh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87r1j4ri6t.fsf@gmail.com \ --to=utkarsh190601@gmail.com \ --cc=47885@debbugs.gnu.org \ --cc=emacs-orgmode@gnu.org \ --cc=mail@nicolasgoaziou.fr \ --subject='Re: [PATCH] org-table-import: Make it more smarter for interactive use' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).