From: Utkarsh Singh <firstname.lastname@example.org>
To: Maxim Nikulin <email@example.com>, firstname.lastname@example.org
Subject: Re: bug#47885: [PATCH] org-table-import: Make it more smarter for interactive use
Date: Sat, 05 Jun 2021 23:20:28 +0530 [thread overview]
Message-ID: <email@example.com> (raw)
On 2021-06-05, 19:40 +0700, Maxim Nikulin <firstname.lastname@example.org> wrote:
> This line should be added to org-table.el, but notice "rx ‘not’ syntax
> error: (or ". This logical operators have a bit different meaning for
> regular expression.
> Nicolas suggested you to use `list' to avoid `eval'. Certainly `eval'
> should be avoided whenever possible, but there is alternative with "`"
> and "," instead of "'". Though I often prefer `list'.
>> Can you also share test.org so that I can test locally?
> I can reproduce it with an empty org file. Emacs-26.3. So I am curious
> if your tested your patch at all.
Yes you are right I was not testing my patches using 'emacs -Q' and I am
apologetic about it. I just "tested" most of them by M-x eval-buffer on
the patched file and then checked the output of `with-temp-buffer'.
>> Now on the topic of CSV parser, I have succesfully implemented a CSV
>> parser in less than 65 LOC which also preserves newline character but I
>> am facing a dilemma on how should I represent it as a Org table. For
>> 6,"Cell with new
> Due to
> "Will there ever be support for multiple lines in a table field? No."
> (there are may be some tricks in Org manual) any variant is acceptable,
> even current one. Since during export split cell is considered as
> different rows, it is responsibility of the user to preprocess original
> file and import it in a form suitable for Org.
> However independently of chosen variant, it would be great to get list
> of warnings with ambiguous lines similar to compiler errors. Such
> feature is not implemented in Org yet, the most close is `org-lint'
> result (its behavior differs from compiler errors).
After reading FAQ about multiple lines in table field I don't think this
PATCH makes much sense as my main driving force for this patch was to
simplify regular expression in `org-table-convert-region' and somehow
add newlines support.
I also think `org-table-convert-region' is doing a fine job and I should
keep my "I want to contribute...." habit in check.
> I expect complexity O(number of lines in result). I do not like
> excessive usage of `dolist'. I would try slicing subrows using `mapcar'
> while there is at least one non-nil element.
Yes! Currently I am trying to sequentially read Elisp manual and I have
completed the section on 'Mapping Function' yesterday. I think it's a
really nice language feature that I can make use of.
> P.S. Have you read "Structure and Interpretation of Computer Programs"
> by Abelson, Sussman, and Sussman?
> or https://mitpress.mit.edu/sites/default/files/sicp/index.html
> While reading, it is necessary to realize that elisp is not scheme, tail
> recursion should be avoided in elisp and there are over differences.
Thank you! I have seen most of the decision on Lisp includes SICP but I
am currently stopping myself to Elisp manual to learn something useful
about this timeless editor and learn thing in a step-by-step manner.
I also tried Racket after reading:
But stopped myself for the reason same as above.
next prev parent reply other threads:[~2021-06-05 18:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 4:43 [PATCH] org-table-import: Make it more smarter for interactive use Utkarsh Singh
2021-04-19 8:19 ` Nicolas Goaziou
2021-04-19 14:23 ` Utkarsh Singh
2021-04-20 13:40 ` Nicolas Goaziou
2021-04-20 17:15 ` Utkarsh Singh
2021-04-23 4:58 ` Utkarsh Singh
2021-04-27 20:21 ` bug#47885: " Nicolas Goaziou
2021-04-28 8:37 ` Utkarsh Singh
2021-04-28 16:38 ` Maxim Nikulin
2021-05-10 18:36 ` Utkarsh Singh
2021-05-12 17:08 ` Maxim Nikulin
2021-05-14 14:54 ` Utkarsh Singh
2021-05-15 9:13 ` Bastien
2021-05-15 10:10 ` Utkarsh Singh
2021-05-15 10:30 ` Bastien
2021-05-15 11:09 ` Utkarsh Singh
2021-05-17 5:29 ` Bastien
2021-05-17 16:27 ` Utkarsh Singh
2021-06-01 16:23 ` Maxim Nikulin
2021-06-01 17:46 ` Utkarsh Singh
2021-06-02 12:06 ` Maxim Nikulin
2021-06-02 15:08 ` Utkarsh Singh
2021-06-02 16:44 ` Maxim Nikulin
2021-06-04 4:04 ` Utkarsh Singh
2021-06-05 12:40 ` Maxim Nikulin
2021-06-05 17:50 ` Utkarsh Singh [this message]
2021-06-09 12:15 ` Maxim Nikulin
2021-09-26 8:40 ` Bastien
2021-05-16 16:24 ` Maxim Nikulin
2021-05-17 16:30 ` Utkarsh Singh
2021-05-18 10:24 ` Utkarsh Singh
2021-05-18 12:31 ` Maxim Nikulin
2021-05-18 15:05 ` Utkarsh Singh
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).