* org-mobile-push failure with git tip
@ 2011-11-16 2:11 Greg Troxel
2011-11-17 12:45 ` Nicolas Goaziou
0 siblings, 1 reply; 3+ messages in thread
From: Greg Troxel @ 2011-11-16 2:11 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Nicolas Goaziou
[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]
I recently updated to the latest git, and found that while everything
else I tried was ok, I got a backtrace when doing org-mobile-push.
Bisecting, I found that the problem commit is:
commit dc62cdcdf11f305149281d16ef2200e18c7abd43
Author: Nicolas Goaziou <n.goaziou@gmail.com>
Date: Sun Oct 23 22:42:48 2011 +0200
org-agenda: Fix small display bug.
* lisp/org-agenda.el: Fix small display bug.
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 32087e3..2bbb832 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3887,7 +3887,7 @@ in `org-agenda-text-search-extra-files'."
(if (not regexps+)
(setq regexp org-outline-regexp-bol)
(setq regexp (pop regexps+))
- (if hdl-only (setq regexp (concat org-outline-regexp-bol " .*?"
+ (if hdl-only (setq regexp (concat org-outline-regexp-bol ".*?"
regexp))))
(setq files (org-agenda-files nil 'ifmode))
(when (eq (car org-agenda-text-search-extra-files) 'agenda-archives)
@@ -4623,7 +4623,7 @@ the documentation of `org-diary'."
(setq marker (org-agenda-new-marker (match-beginning 0))
category (org-get-category)
org-category-pos (get-text-property (point) 'org-category-position)
- txt (match-string 2)
+ txt (buffer-substring (match-beginning 2) (match-end 3))
tags (org-get-tags-at (point))
txt (org-agenda-format-item "" txt category tags)
priority (1+ (org-get-priority txt))
and by moving to origin/master and then reverting that one commit, all
seems well. I can send more information if needed, but I'm guessing the
above report will make the problem apparent.
[-- Attachment #2: Type: application/pgp-signature, Size: 194 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: org-mobile-push failure with git tip
2011-11-16 2:11 org-mobile-push failure with git tip Greg Troxel
@ 2011-11-17 12:45 ` Nicolas Goaziou
2011-11-17 13:13 ` Greg Troxel
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2011-11-17 12:45 UTC (permalink / raw)
To: Greg Troxel; +Cc: emacs-orgmode
Hello,
Greg Troxel <gdt@ir.bbn.com> writes:
> I recently updated to the latest git, and found that while everything
> else I tried was ok, I got a backtrace when doing org-mobile-push.
> Bisecting, I found that the problem commit is:
>
> commit dc62cdcdf11f305149281d16ef2200e18c7abd43
> Author: Nicolas Goaziou <n.goaziou@gmail.com>
> Date: Sun Oct 23 22:42:48 2011 +0200
>
> org-agenda: Fix small display bug.
>
> * lisp/org-agenda.el: Fix small display bug.
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 32087e3..2bbb832 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -3887,7 +3887,7 @@ in `org-agenda-text-search-extra-files'."
> (if (not regexps+)
> (setq regexp org-outline-regexp-bol)
> (setq regexp (pop regexps+))
> - (if hdl-only (setq regexp (concat org-outline-regexp-bol " .*?"
> + (if hdl-only (setq regexp (concat org-outline-regexp-bol ".*?"
> regexp))))
> (setq files (org-agenda-files nil 'ifmode))
> (when (eq (car org-agenda-text-search-extra-files) 'agenda-archives)
> @@ -4623,7 +4623,7 @@ the documentation of `org-diary'."
> (setq marker (org-agenda-new-marker (match-beginning 0))
> category (org-get-category)
> org-category-pos (get-text-property (point) 'org-category-position)
> - txt (match-string 2)
> + txt (buffer-substring (match-beginning 2) (match-end 3))
> tags (org-get-tags-at (point))
> txt (org-agenda-format-item "" txt category tags)
> priority (1+ (org-get-priority txt))
I've recently pushed a patch around that area. Does the problem persist
with the latest git ?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: org-mobile-push failure with git tip
2011-11-17 12:45 ` Nicolas Goaziou
@ 2011-11-17 13:13 ` Greg Troxel
0 siblings, 0 replies; 3+ messages in thread
From: Greg Troxel @ 2011-11-17 13:13 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
[problem with org-mobile-push from commit
dc62cdcdf11f305149281d16ef2200e18c7abd43
]
I've recently pushed a patch around that area. Does the problem persist
with the latest git ?
Thanks. I updated (to 7c21098323bf0097c7903b014564cd6056bda374) and now
all is well.
[-- Attachment #2: Type: application/pgp-signature, Size: 194 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-17 13:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-16 2:11 org-mobile-push failure with git tip Greg Troxel
2011-11-17 12:45 ` Nicolas Goaziou
2011-11-17 13:13 ` Greg Troxel
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).