emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Greg Troxel <gdt@ir.bbn.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-mobile-push failure with git tip
Date: Thu, 17 Nov 2011 13:45:29 +0100	[thread overview]
Message-ID: <874ny2rk7q.fsf@gmail.com> (raw)
In-Reply-To: <rmik470g6jk.fsf@fnord.ir.bbn.com> (Greg Troxel's message of "Tue, 15 Nov 2011 21:11:43 -0500")

Hello,

Greg Troxel <gdt@ir.bbn.com> writes:

> I recently updated to the latest git, and found that while everything
> else I tried was ok, I got a backtrace when doing org-mobile-push.
> Bisecting, I found that the problem commit is:
>
> commit dc62cdcdf11f305149281d16ef2200e18c7abd43
> Author: Nicolas Goaziou <n.goaziou@gmail.com>
> Date:   Sun Oct 23 22:42:48 2011 +0200
>
>     org-agenda: Fix small display bug.
>     
>     * lisp/org-agenda.el: Fix small display bug.
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 32087e3..2bbb832 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -3887,7 +3887,7 @@ in `org-agenda-text-search-extra-files'."
>      (if (not regexps+)
>  	(setq regexp org-outline-regexp-bol)
>        (setq regexp (pop regexps+))
> -      (if hdl-only (setq regexp (concat org-outline-regexp-bol " .*?"
> +      (if hdl-only (setq regexp (concat org-outline-regexp-bol ".*?"
>  					regexp))))
>      (setq files (org-agenda-files nil 'ifmode))
>      (when (eq (car org-agenda-text-search-extra-files) 'agenda-archives)
> @@ -4623,7 +4623,7 @@ the documentation of `org-diary'."
>  	(setq marker (org-agenda-new-marker (match-beginning 0))
>  	      category (org-get-category)
>  	      org-category-pos (get-text-property (point) 'org-category-position)
> -	      txt (match-string 2)
> +	      txt (buffer-substring (match-beginning 2) (match-end 3))
>  	      tags (org-get-tags-at (point))
>  	      txt (org-agenda-format-item "" txt category tags)
>  	      priority (1+ (org-get-priority txt))

I've recently pushed a patch around that area. Does the problem persist
with the latest git ?


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2011-11-17 12:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-16  2:11 org-mobile-push failure with git tip Greg Troxel
2011-11-17 12:45 ` Nicolas Goaziou [this message]
2011-11-17 13:13   ` Greg Troxel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ny2rk7q.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=gdt@ir.bbn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).