From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Cc: "Christian Köstlin" <christian.koestlin@gmail.com>
Subject: Re: [PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el
Date: Sun, 2 Oct 2022 09:47:18 +0700 [thread overview]
Message-ID: <f1081407-ee8a-b412-3c85-591a2d1b89a3@gmail.com> (raw)
In-Reply-To: <CAG741+ajzNMyyqg0m6EFP=_BCKjayiK-H_FpPhaY1T9=V+NPkA@mail.gmail.com>
On 02/10/2022 05:05, Christian Köstlin wrote:
> Aforementioned unit-test.
> +(ert-deftest ob-D/dub-basics ()
> + (if (executable-find "dub") (org-test-at-id
> + "81E17302-BE76-4E2A-93CA-0A7E121CB7C2" (org-babel-next-src-block 1)
> + (should (equal "abc, bac, cab, acb, bca, cba, "
> + (org-babel-execute-src-block))))))
I am unsure concerning general policy related to org-babel test, so the
following is rather discussion than a direct request to change the test.
Is there a way to avoid dependency on remote resources? My concern is
test results affected by network issues. In addition, more required 3rd
party tools means less probability that a developer after modification
of generic babel code noticed that the changes break D backend because
missing tool on the development machine. I have no idea how much efforts
is required to create a mock for isolated environment.
Another point is that missed dub binary is not reflected in test report.
If `skip-unless' feature of ert is available in Emacs-26 then it should
be used.
next prev parent reply other threads:[~2022-10-02 2:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 22:05 [PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el Christian Köstlin
2022-10-02 2:47 ` Max Nikulin [this message]
2022-10-02 7:29 ` Ihor Radchenko
[not found] ` <CAG741+aejhxeGf9hwW5i2tw_yokbudO8tPsh0h5Fjcp+PXduJQ@mail.gmail.com>
[not found] ` <8735c5zhth.fsf@localhost>
[not found] ` <CAG741+ZsxPOwNP190x=t=QrAJSM5s-GTFowRaNs07PnMd03OzA@mail.gmail.com>
[not found] ` <87h70lw1k4.fsf@localhost>
[not found] ` <CAG741+aNbNKqK_w6=+OYNWJSV+3bY_=QO3hzhs8ztC6Opit3vA@mail.gmail.com>
2022-10-04 4:56 ` Ihor Radchenko
2022-10-18 19:46 ` tbanelwebmin
2022-10-19 8:07 ` Ihor Radchenko
2023-09-01 11:50 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1081407-ee8a-b412-3c85-591a2d1b89a3@gmail.com \
--to=manikulin@gmail.com \
--cc=christian.koestlin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).