emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org,
	"Christian Köstlin" <christian.koestlin@gmail.com>
Subject: Re: [PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el
Date: Sun, 02 Oct 2022 15:29:23 +0800	[thread overview]
Message-ID: <8735c61y5o.fsf@localhost> (raw)
In-Reply-To: <f1081407-ee8a-b412-3c85-591a2d1b89a3@gmail.com>

Max Nikulin <manikulin@gmail.com> writes:

> I am unsure concerning general policy related to org-babel test, so the 
> following is rather discussion than a direct request to change the test.
>
> Is there a way to avoid dependency on remote resources? My concern is 
> test results affected by network issues. In addition, more required 3rd 
> party tools means less probability that a developer after modification 
> of generic babel code noticed that the changes break D backend because 
> missing tool on the development machine. I have no idea how much efforts 
> is required to create a mock for isolated environment.

Tests must not rely on remote resources.
However, it does not mean that we cannot test remote resources in Org
tests. One simply needs to mock the url-retrieve or whatever function is
used to retrieve remove resource.

> Another point is that missed dub binary is not reflected in test report. 
> If `skip-unless' feature of ert is available in Emacs-26 then it should 
> be used.

The current approach to optional binaries is throwing
'missing-test-dependency error when the binary is not available.

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92


  reply	other threads:[~2022-10-02  7:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-01 22:05 [PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el Christian Köstlin
2022-10-02  2:47 ` Max Nikulin
2022-10-02  7:29   ` Ihor Radchenko [this message]
     [not found]     ` <CAG741+aejhxeGf9hwW5i2tw_yokbudO8tPsh0h5Fjcp+PXduJQ@mail.gmail.com>
     [not found]       ` <8735c5zhth.fsf@localhost>
     [not found]         ` <CAG741+ZsxPOwNP190x=t=QrAJSM5s-GTFowRaNs07PnMd03OzA@mail.gmail.com>
     [not found]           ` <87h70lw1k4.fsf@localhost>
     [not found]             ` <CAG741+aNbNKqK_w6=+OYNWJSV+3bY_=QO3hzhs8ztC6Opit3vA@mail.gmail.com>
2022-10-04  4:56               ` Ihor Radchenko
2022-10-18 19:46     ` tbanelwebmin
2022-10-19  8:07       ` Ihor Radchenko
2023-09-01 11:50 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735c61y5o.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=christian.koestlin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=manikulin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).