From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YHUyL+X7OGPrBwAAbAwnHQ (envelope-from ) for ; Sun, 02 Oct 2022 04:48:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mK01L+X7OGN9MgAAauVa8A (envelope-from ) for ; Sun, 02 Oct 2022 04:48:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 623472CB50 for ; Sun, 2 Oct 2022 04:48:05 +0200 (CEST) Received: from localhost ([::1]:58466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oep1Q-0005t4-Bt for larch@yhetil.org; Sat, 01 Oct 2022 22:48:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oep0o-0005sm-0H for emacs-orgmode@gnu.org; Sat, 01 Oct 2022 22:47:26 -0400 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:34601) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oep0m-0003WC-FQ for emacs-orgmode@gnu.org; Sat, 01 Oct 2022 22:47:25 -0400 Received: by mail-lf1-x135.google.com with SMTP id j16so12218073lfg.1 for ; Sat, 01 Oct 2022 19:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:cc:to:from:references :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=Onl0hlSi8h5n3qiBZJ6BLXf+7IEuMF4Ba0PREnOH6lU=; b=YvHmpgaQ7J0yMk4o+7cXYCp/18eJFQGmhOuoYHHiaLy8aFkv9dP1peDGfRLsiOxKp2 q015r/6BZNvwSkNwYmfSQGhS7FleMijBvkmssUio8moDQJNyPlN9Uhs9IYA/BGgwosp4 5J7H6bDUHU6vcG1BkjW+npHP5AocaG7RkXaHmdoFeRkcmIUjewucMghCuq34w+E8IDCY cJjg/Qck02sIfmQHOeH9796jslxX85WROQtKqMvS/Fh9Z97YmoZfU7+6Ch5oerA6DoRr jlqKq2kxotZFC8qfsjWi0AP+G+5NWKTout4M3m7etN7IK6neNAFUOpCn2/tX+3lRQgKu /iIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:cc:to:from:references :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=Onl0hlSi8h5n3qiBZJ6BLXf+7IEuMF4Ba0PREnOH6lU=; b=nmyNHJfcI9Fv67u9XyYtAL/tX4cXEvRL1lCY1F0YwizT1lNHofF+cP2Oad6n6hQvli m89MivHVV/c+OJif1tb/m8j+YFsnfu4wg/9prwi2mFCjWH97OUov6dtrZZheNh2zYsHf Wj3MeE3JDuJ7Y7nW5ZfbKtEG6fEazWIPof2JS8pxNpy6JlJmKTzGdYlBSxObpNePAWL/ NDoFn+UlEJmpVmAb/0k0nWXxN4EVySS1lgdB+fQdZrLEawNe5dGD8qTg9W3cdz+NgEg/ +LA4OlhlnljjETnjiBOYRX9MuELH7pE1bRiEfP+gKv314MS9OxTvSK38b9aOOlz3cUvK J3Wg== X-Gm-Message-State: ACrzQf3H8ZBpaD1ncXZCZfKk7zA5zJoXMaiNtX1UVwbdzDfM94jZcH/b VDauaOKDlFmGUYBIH6cTcVuza7eN8eQ= X-Google-Smtp-Source: AMsMyM7cLWsADTasZgjxbfrGqLlSiTw2RejMDCZhm1lU3L44UuIf9oRXjU0+qiRDkvPIQ3GD8NoHLw== X-Received: by 2002:a05:6512:308f:b0:49a:5a59:aa25 with SMTP id z15-20020a056512308f00b0049a5a59aa25mr5158479lfd.44.1664678841731; Sat, 01 Oct 2022 19:47:21 -0700 (PDT) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id bx30-20020a05651c199e00b0026acfbbcb7esm17134ljb.12.2022.10.01.19.47.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Oct 2022 19:47:20 -0700 (PDT) Message-ID: Date: Sun, 2 Oct 2022 09:47:18 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el Content-Language: en-US References: From: Max Nikulin To: emacs-orgmode@gnu.org Cc: =?UTF-8?Q?Christian_K=c3=b6stlin?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::135; envelope-from=manikulin@gmail.com; helo=mail-lf1-x135.google.com X-Spam_score_int: -47 X-Spam_score: -4.8 X-Spam_bar: ---- X-Spam_report: (-4.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-2.743, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664678885; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Onl0hlSi8h5n3qiBZJ6BLXf+7IEuMF4Ba0PREnOH6lU=; b=fDNYYJk7qUde6AGMCdm99KnLHD5djQBRxVSdyd1uWDE2CupOI/ABd0c1Go8m4ax41zXeai C7McX2jgdqyadEfpzNWflAvxtsDlUPSHt+NCJwVsrMrH5pF06yD+bQEAPDqKBPvHcC/NgJ 0fAiG5nP5Z5vrMftTE1eQWgdg42FhwMVkeKiPb6HPxwglodx2CFGxKrG6GoPZoYBaWo3M2 Yobm+sXiL3OnPZB21soA9mugQlOVvysWdSxgAE5cMGkNaatHxETmf4ZOL0MjYf47WnwiMr irt8Xmxx4Lmz/wqWUsc4exurzQu5NQqwMmkx9qVxenvKuopjSBnDDQ3paqYzMA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664678885; a=rsa-sha256; cv=none; b=HYdtu4tJboMcHWR6HktQKULlg1e9ORm+3UR+YaGyBSJE4NLlHPPE7qwpkPCKmAMBd3YaP3 6zYLPiso6sJbYDhy5e4YLa8nhh8pDddPfH7vJsvEMtL0FWFWQCFaFYEacUGvE6jQUxfyeh k0wwwCy5eeQ7HTWNP03y7NHSxn/7piOlMc/rRLOcFnoZik1XMZy48Bn5WPcF40VXRpIilR VaEbFEJl+mMyOqNgsP0kwqwsPELg8UXjmA1+CajgcmKacDj0DVrT1NrkDpFqSukU99cywU rHjE9jR4DaQKQnGBcoYc2GW5KfL6C4b16Gkbu9Aj16Uw9QyTamRpIgqYLrQzcQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=YvHmpgaQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=YvHmpgaQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 623472CB50 X-Spam-Score: 7.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: /j6NnBDUtlzV On 02/10/2022 05:05, Christian Köstlin wrote: > Aforementioned unit-test. > +(ert-deftest ob-D/dub-basics () > + (if (executable-find "dub") (org-test-at-id > + "81E17302-BE76-4E2A-93CA-0A7E121CB7C2" (org-babel-next-src-block 1) > + (should (equal "abc, bac, cab, acb, bca, cba, " > + (org-babel-execute-src-block)))))) I am unsure concerning general policy related to org-babel test, so the following is rather discussion than a direct request to change the test. Is there a way to avoid dependency on remote resources? My concern is test results affected by network issues. In addition, more required 3rd party tools means less probability that a developer after modification of generic babel code noticed that the changes break D backend because missing tool on the development machine. I have no idea how much efforts is required to create a mock for isolated environment. Another point is that missed dub binary is not reflected in test report. If `skip-unless' feature of ert is available in Emacs-26 then it should be used.