From: Ignacio Casso <ignaciocasso@hotmail.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] link abbreviations do not work inside property drawers [9.5.2 (release_9.5.2-38-g682ccd @ /home/ignacio/repos/emacs/lisp/org/)]
Date: Tue, 26 Apr 2022 16:46:31 +0200 [thread overview]
Message-ID: <PAXPR06MB77609A16D843AEA8A84629FBC6FB9@PAXPR06MB7760.eurprd06.prod.outlook.com> (raw)
In-Reply-To: <8735i0vtn7.fsf@localhost>
>> (cond ((org-in-regexp org-link-any-re)
>> (let ((org-link-abbrev-alist
>> (append org-link-abbrev-alist org-link-abbrev-alist-local)))
>> (org-link-open-from-string (match-string-no-properties 0))))
>> ...)
>> ...
>> What do you think?
>
> I do not like this idea. There is also org-link-abbrev-alist-local and
> potentially other variables to be introduced in future. We should not
> rely too much on internal workings of ol.el.
>
> A better approach could be using org-link-expand-abbrev. It is an API
> function and should be forward-compatible.
Do you mean something like this?
(defun org-open-at-point-global ()
...
(cond ((org-in-regexp org-link-any-re)
(org-link-open-from-string
(org-link-expand-abbrev (match-string-no-properties 0))))
...))
Right now that is not enough because `org-link-expand-abbrev' only works
for links without square brackets, like "abbrev:suffix", and
`org-link-any-re' matches links with square brackets, like
"[[abbrev:suffix]]". That could be easily worked around in
`org-open-at-point-global' but maybe it would be better to change
`org-link-expand-abbrev' to work with both forms.
Let me know if you want me to send a patch implementing any of those
options or any other that you see fit. Otherwise, I know enough now to
fix the issue in my own config, so we can leave at that.
Regards,
--Ignacio
next prev parent reply other threads:[~2022-04-26 15:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 9:53 [BUG] link abbreviations do not work inside property drawers [9.5.2 (release_9.5.2-38-g682ccd @ /home/ignacio/repos/emacs/lisp/org/)] Ignacio Casso
2022-04-24 7:40 ` Ihor Radchenko
2022-04-24 9:45 ` Ignacio Casso
2022-04-26 8:49 ` Ihor Radchenko
2022-04-26 9:07 ` Ignacio Casso
2022-04-26 13:52 ` Ihor Radchenko
2022-04-26 14:46 ` Ignacio Casso [this message]
2022-04-27 4:25 ` Ihor Radchenko
2022-04-27 6:46 ` Ignacio Casso
2022-04-27 9:18 ` tony aldon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAXPR06MB77609A16D843AEA8A84629FBC6FB9@PAXPR06MB7760.eurprd06.prod.outlook.com \
--to=ignaciocasso@hotmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).