From: Ihor Radchenko <yantar92@gmail.com>
To: Ignacio Casso <ignaciocasso@hotmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] link abbreviations do not work inside property drawers [9.5.2 (release_9.5.2-38-g682ccd @ /home/ignacio/repos/emacs/lisp/org/)]
Date: Tue, 26 Apr 2022 16:49:47 +0800 [thread overview]
Message-ID: <878rrsut3o.fsf@localhost> (raw)
In-Reply-To: <PAXPR06MB77609467579F3DD6D11225EBC6F99@PAXPR06MB7760.eurprd06.prod.outlook.com>
Ignacio Casso <ignaciocasso@hotmail.com> writes:
> Actually, I have investigated a little bit and I think the issue is more simple
> than that:
>
> - Link abbreviations rely in the variables `org-link-abbrev-alist' for
> global abbreviations and `org-link-abbrev-alist-local' for
> abbreviations defined with #+LINK for a single org file.
>
> - `org-open-at-point-global' opens links with
> `org-link-open-from-string' as opposed to `org-open-at-point', which
> uses `org-link-open'.
>
> - `org-link-open-from-string' ends up using `org-link-open' too, but
> inside a `with-temp-buffer' form:
> ...
> So a simple solution to this would be preserving the value of
> `org-link-abbrev-alist-local' when switching to the temporal buffer. I
> think this is orthogonal to the issue of the parser, and it's a bug on
> its own, since as a user I would expect that evaluating
> `org-link-open-from-string' would use my current buffer's local values
> of variables.
I am not sure if using current buffer in `org-link-open-from-string' is
to be expected. This function is not tied to buffer, just to string.
Imagine a situation when user function retrieves the link string from
another buffer and then calls `org-link-org-from-string' in the context
of current buffer. What you are proposing is going to change the current
behaviour of `org-link-open-from-string' beyond the discussed problem.
Instead of changing the default behaviour of
`org-link-open-from-string', I would introduce an optional parameter
holding the desired context. The parameter can be set to an Org buffer.
That buffer's context will be used.
> P.S. There is another variable defined with `defvar-local' in ol.el:
> `org-target-link-regexp'. I don't know what it is used for but it could
> potentially suffer from the same problem.
A clean solution would do something similar to
org-export--generate-copy-script.
Best,
Ihor
next prev parent reply other threads:[~2022-04-26 8:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 9:53 [BUG] link abbreviations do not work inside property drawers [9.5.2 (release_9.5.2-38-g682ccd @ /home/ignacio/repos/emacs/lisp/org/)] Ignacio Casso
2022-04-24 7:40 ` Ihor Radchenko
2022-04-24 9:45 ` Ignacio Casso
2022-04-26 8:49 ` Ihor Radchenko [this message]
2022-04-26 9:07 ` Ignacio Casso
2022-04-26 13:52 ` Ihor Radchenko
2022-04-26 14:46 ` Ignacio Casso
2022-04-27 4:25 ` Ihor Radchenko
2022-04-27 6:46 ` Ignacio Casso
2022-04-27 9:18 ` tony aldon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rrsut3o.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=ignaciocasso@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).