emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ignacio Casso <ignaciocasso@hotmail.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] link abbreviations do not work inside property drawers [9.5.2 (release_9.5.2-38-g682ccd @ /home/ignacio/repos/emacs/lisp/org/)]
Date: Tue, 26 Apr 2022 11:07:44 +0200	[thread overview]
Message-ID: <PAXPR06MB7760D4D87CBFB3823E8AFED2C6FB9@PAXPR06MB7760.eurprd06.prod.outlook.com> (raw)
In-Reply-To: <878rrsut3o.fsf@localhost>


Ihor Radchenko <yantar92@gmail.com> writes:

> Ignacio Casso <ignaciocasso@hotmail.com> writes:
>
>> So a simple solution to this would be preserving the value of
>> `org-link-abbrev-alist-local' when switching to the temporal buffer. I
>> think this is orthogonal to the issue of the parser, and it's a bug on
>> its own, since as a user I would expect that evaluating
>> `org-link-open-from-string' would use my current buffer's local values
>> of variables.
>
> I am not sure if using current buffer in `org-link-open-from-string' is
> to be expected. This function is not tied to buffer, just to string.
> Imagine a situation when user function retrieves the link string from
> another buffer and then calls `org-link-org-from-string' in the context
> of current buffer. What you are proposing is going to change the current
> behaviour of `org-link-open-from-string' beyond the discussed problem.
>
> Instead of changing the default behaviour of
> `org-link-open-from-string', I would introduce an optional parameter
> holding the desired context. The parameter can be set to an Org buffer.
> That buffer's context will be used.

I agree that changing the current behavior of
`org-link-open-from-string' may be problematic, however I don't think
that it's worth to introduce the optional argument just for this "bug".
I would just use the let from I suggested:

  (let ((org-link-abbrev-alist
         (append org-link-abbrev-alist org-link-abbrev-alist-local)))
    ...)

but instead of doing it in the definition of
`org-link-open-from-string', do it in `org-open-at-point-global',
like this:

(cond ((org-in-regexp org-link-any-re)
       (let ((org-link-abbrev-alist
              (append org-link-abbrev-alist org-link-abbrev-alist-local)))
	 (org-link-open-from-string (match-string-no-properties 0))))
      ...)

or in `org-open-at-point', like this:

  (cond
   ...
   ((memq type '(comment comment-block node-property keyword))
    (let ((org-link-abbrev-alist
           (append org-link-abbrev-alist org-link-abbrev-alist-local)))
      (call-interactively #'org-open-at-point-global)))
   ...)

What do you think?

--Ignacio

next prev parent reply	other threads:[~2022-04-26  9:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-23  9:53 [BUG] link abbreviations do not work inside property drawers [9.5.2 (release_9.5.2-38-g682ccd @ /home/ignacio/repos/emacs/lisp/org/)] Ignacio Casso
2022-04-24  7:40 ` Ihor Radchenko
2022-04-24  9:45   ` Ignacio Casso
2022-04-26  8:49     ` Ihor Radchenko
2022-04-26  9:07       ` Ignacio Casso [this message]
2022-04-26 13:52         ` Ihor Radchenko
2022-04-26 14:46           ` Ignacio Casso
2022-04-27  4:25             ` Ihor Radchenko
2022-04-27  6:46               ` Ignacio Casso
2022-04-27  9:18                 ` tony aldon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PAXPR06MB7760D4D87CBFB3823E8AFED2C6FB9@PAXPR06MB7760.eurprd06.prod.outlook.com \
    --to=ignaciocasso@hotmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).