emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-agenda-file-regexp not used in org.el?
Date: Wed, 2 Jan 2008 23:05:27 +0100	[thread overview]
Message-ID: <E8E4BB84-02A6-45C0-9D65-6E11F89DC568@gmail.com> (raw)
In-Reply-To: <873atlu274.fsf@bzg.ath.cx>

Bummer!

Fixed for next version, of course.  Thanks for report and fix.

- Carsten

On Dec 29, 2007, at 1:15 PM, Bastien wrote:

> Wanrong Lin <wanrong.lin@gmail.com> writes:
>
>> I am trying to customize the org-agenda-file-regexp variable to  
>> exclude
>> those auto backup files starting with "#", but found out the regexp  
>> does
>> not have any effect on agend file list. And I further found out it  
>> seems
>> the variable org-agenda-file-regexp is not used in org.el at all. In
>> function "org-agenda-files", the regular expression is hard coded to
>> "\\.org\\'", as in these two lines:
>>
>> (if (file-directory-p f)
>>    (directory-files f t "\\.org\\'")
>>
>> I wonder whether this is a bug and should be fixed. Thank you.
>
> I think this should be fixed.  Here is a patch.
>
> diff -u /home/guerry/elisp/testing/org/ /home/guerry/elisp/testing/ 
> bzg/org.el
> --- /home/guerry/elisp/testing/org/org.el	2007-12-20  
> 14:38:42.000000000 +0100
> +++ /home/guerry/elisp/testing/bzg/org.el	2007-12-29  
> 13:13:03.000000000 +0100
> @@ -19618,7 +19618,7 @@
>     (setq files (apply 'append
> 		       (mapcar (lambda (f)
> 				 (if (file-directory-p f)
> -				     (directory-files f t "\\.org\\'")
> +				     (directory-files f t org-agenda-file-regexp)
> 				   (list f)))
> 			       files)))
>     (if org-agenda-skip-unavailable-files
>
> Diff finished.  Sat Dec 29 13:13:41 2007
>
> -- 
> Bastien
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

      reply	other threads:[~2008-01-02 22:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-26 21:28 Bug: org-agenda-file-regexp not used in org.el? Wanrong Lin
2007-12-29 12:15 ` Bastien
2008-01-02 22:05   ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E8E4BB84-02A6-45C0-9D65-6E11F89DC568@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).