From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Bug: org-agenda-file-regexp not used in org.el? Date: Wed, 2 Jan 2008 23:05:27 +0100 Message-ID: References: <4772C799.5020409@gmail.com> <873atlu274.fsf@bzg.ath.cx> Mime-Version: 1.0 (Apple Message framework v915) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JABiW-0003lU-Od for emacs-orgmode@gnu.org; Wed, 02 Jan 2008 17:05:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JABiU-0003lI-IX for emacs-orgmode@gnu.org; Wed, 02 Jan 2008 17:05:39 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JABiU-0003lF-Cl for emacs-orgmode@gnu.org; Wed, 02 Jan 2008 17:05:38 -0500 Received: from mu-out-0910.google.com ([209.85.134.190]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JABiT-0002ig-S9 for emacs-orgmode@gnu.org; Wed, 02 Jan 2008 17:05:38 -0500 Received: by mu-out-0910.google.com with SMTP id g7so3803687muf.0 for ; Wed, 02 Jan 2008 14:05:35 -0800 (PST) In-Reply-To: <873atlu274.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org Bummer! Fixed for next version, of course. Thanks for report and fix. - Carsten On Dec 29, 2007, at 1:15 PM, Bastien wrote: > Wanrong Lin writes: > >> I am trying to customize the org-agenda-file-regexp variable to >> exclude >> those auto backup files starting with "#", but found out the regexp >> does >> not have any effect on agend file list. And I further found out it >> seems >> the variable org-agenda-file-regexp is not used in org.el at all. In >> function "org-agenda-files", the regular expression is hard coded to >> "\\.org\\'", as in these two lines: >> >> (if (file-directory-p f) >> (directory-files f t "\\.org\\'") >> >> I wonder whether this is a bug and should be fixed. Thank you. > > I think this should be fixed. Here is a patch. > > diff -u /home/guerry/elisp/testing/org/ /home/guerry/elisp/testing/ > bzg/org.el > --- /home/guerry/elisp/testing/org/org.el 2007-12-20 > 14:38:42.000000000 +0100 > +++ /home/guerry/elisp/testing/bzg/org.el 2007-12-29 > 13:13:03.000000000 +0100 > @@ -19618,7 +19618,7 @@ > (setq files (apply 'append > (mapcar (lambda (f) > (if (file-directory-p f) > - (directory-files f t "\\.org\\'") > + (directory-files f t org-agenda-file-regexp) > (list f))) > files))) > (if org-agenda-skip-unavailable-files > > Diff finished. Sat Dec 29 13:13:41 2007 > > -- > Bastien > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode