emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: Wanrong Lin <wanrong.lin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-agenda-file-regexp not used in org.el?
Date: Sat, 29 Dec 2007 13:15:27 +0100	[thread overview]
Message-ID: <873atlu274.fsf@bzg.ath.cx> (raw)
In-Reply-To: <4772C799.5020409@gmail.com> (Wanrong Lin's message of "Wed, 26 Dec 2007 16:28:57 -0500")

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

Wanrong Lin <wanrong.lin@gmail.com> writes:

> I am trying to customize the org-agenda-file-regexp variable to exclude
> those auto backup files starting with "#", but found out the regexp does
> not have any effect on agend file list. And I further found out it seems
> the variable org-agenda-file-regexp is not used in org.el at all. In
> function "org-agenda-files", the regular expression is hard coded to
> "\\.org\\'", as in these two lines:
>
> (if (file-directory-p f)
>     (directory-files f t "\\.org\\'")
>
> I wonder whether this is a bug and should be fixed. Thank you.

I think this should be fixed.  Here is a patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org.el.patch --]
[-- Type: text/x-diff, Size: 574 bytes --]

diff -u /home/guerry/elisp/testing/org/ /home/guerry/elisp/testing/bzg/org.el
--- /home/guerry/elisp/testing/org/org.el	2007-12-20 14:38:42.000000000 +0100
+++ /home/guerry/elisp/testing/bzg/org.el	2007-12-29 13:13:03.000000000 +0100
@@ -19618,7 +19618,7 @@
     (setq files (apply 'append
 		       (mapcar (lambda (f)
 				 (if (file-directory-p f)
-				     (directory-files f t "\\.org\\'")
+				     (directory-files f t org-agenda-file-regexp)
 				   (list f)))
 			       files)))
     (if org-agenda-skip-unavailable-files

Diff finished.  Sat Dec 29 13:13:41 2007

[-- Attachment #3: Type: text/plain, Size: 13 bytes --]


-- 
Bastien

[-- Attachment #4: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

  reply	other threads:[~2007-12-29 12:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-26 21:28 Bug: org-agenda-file-regexp not used in org.el? Wanrong Lin
2007-12-29 12:15 ` Bastien [this message]
2008-01-02 22:05   ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873atlu274.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=wanrong.lin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).