From: Michael Brand <michael.ch.brand@gmail.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: "git describe" in version of info file with "make info_git_describe"
Date: Thu, 27 Oct 2011 20:24:51 +0200 [thread overview]
Message-ID: <CALn3zohhKO2hGtMbqbAGN4LyUf_W1izg2J_jRXV4ySDm9Q5Ztw@mail.gmail.com> (raw)
In-Reply-To: <87fwifwv1s.fsf@Rainer.invalid>
[-- Attachment #1: Type: text/plain, Size: 1772 bytes --]
Hi Achim
Thank you for your review.
On Wed, Oct 26, 2011 at 18:56, Achim Gratz <Stromeko@nexgo.de> wrote:
> The set-version.pl file may be obsolete (perl is still required),
If set-version.pl would be obsolete my patch would be much shorter and I
would use something even more portable than perl to change the version in
/tmp/org.texi like the POSIX/SUS ed command, used inline in the Makefile.
Would you agree?
> there is no version number in the individual lisp files anymore. For
> installation I've already added a replacement of the version cookie in
> org.el with git-describe in my own fork of org-mode ([1] - I don't know if
> you've checked it). It would be easy to do the same for org-texi,
> albeit before compilation, not only during install.
I can remember some discussion but haven't realized that the outcome is a
pending merge. Hence I declare version 2 of my patch as "Changes Requested"
on patchwork (can't change this myself) and will rebase it against your
changes.
> I agree it would be useful to have the full version recorded in the
> resulting manual, but you really cannot alter the source file (git
> status would always be dirty or the version would be wrong, wouldn't it?
> :-).
Yes, good point. I was aware of that and therefore for the target "info-vg",
doc/org.texi is copied to /tmp/org.texi, altered only there and makeinfo
reads from there.
And I _added_ the target "info-vg" because implementing the same
functionality in the target "info" itself, by either adding an auto-detect
whether git describe is available (like org-version does) or using
org-version itself, is not an option. One still needs to have the unchanged
target "info" to build a release with the info version not possibly
influenced by git describe.
Michael
[-- Attachment #2: Type: text/html, Size: 2110 bytes --]
next prev parent reply other threads:[~2011-10-27 18:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 14:11 "git describe" in version of info file with "make info_git_describe" Michael Brand
2011-06-02 14:47 ` Bernt Hansen
2011-06-02 15:05 ` Michael Brand
2011-06-02 19:36 ` Michael Brand
2011-10-16 19:12 ` Michael Brand
2011-10-21 14:44 ` Carsten Dominik
2011-10-21 16:13 ` Bernt Hansen
2011-10-23 22:50 ` Bernt Hansen
2011-10-26 16:07 ` Michael Brand
2011-10-26 16:56 ` Achim Gratz
2011-10-27 18:24 ` Michael Brand [this message]
2011-10-28 9:26 ` Achim Gratz
2011-10-29 11:40 ` Michael Brand
2011-10-30 7:01 ` Achim Gratz
2011-10-30 14:20 ` Michael Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALn3zohhKO2hGtMbqbAGN4LyUf_W1izg2J_jRXV4ySDm9Q5Ztw@mail.gmail.com \
--to=michael.ch.brand@gmail.com \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).