emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Michael Brand <michael.ch.brand@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>,
	Bastien Guerry <bzg@altern.org>
Cc: Bernt Hansen <bernt@norang.ca>, Org Mode <emacs-orgmode@gnu.org>
Subject: Re: "git describe" in version of info file with "make info_git_describe"
Date: Wed, 26 Oct 2011 18:07:58 +0200	[thread overview]
Message-ID: <CALn3zogQ0NB-WoNuQZaPjJyBvvkJE_pr-dcjhX5KJUtGxQV=Aw@mail.gmail.com> (raw)
In-Reply-To: <FC51430D-1349-40F3-AA32-6F0B44A018F9@gmail.com>

Hi Carsten and Bastien

On Fri, Oct 21, 2011 at 16:44, Carsten Dominik
<carsten.dominik@gmail.com> wrote:
> is there an agreement that this is a good patch?  I have not followed the discussion.....

Let me summarize:

> On Oct 16, 2011, at 9:12 PM, Michael Brand wrote:
>> The previous patch attachment had a wrong mime type, could therefore
>> not be caught by patchwork and has not been accepted.
Only a clarification about "has not been accepted": The first version
of my patch has just not been applied, there was no disagreement or
reject. The second version was only to get my patch into patchwork at
all and to rebase it at the design level.

For the change in org-version (substitution of the "-" from the git
tag delivered by git describe with "."): As Bernt is the author of
this substitution I originally asked him if I could remove it to align
with the output of git describe and he agreed. He now has reviewed
this part of the second version of my patch and he is fine with it.

There has not yet been any review or comment on the changes in the
Makefile and in UTILITIES/set-version.pl. I would be happy if these
parts could be reviewed too.

Michael

next prev parent reply	other threads:[~2011-10-26 16:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 14:11 "git describe" in version of info file with "make info_git_describe" Michael Brand
2011-06-02 14:47 ` Bernt Hansen
2011-06-02 15:05   ` Michael Brand
2011-06-02 19:36     ` Michael Brand
2011-10-16 19:12       ` Michael Brand
2011-10-21 14:44         ` Carsten Dominik
2011-10-21 16:13           ` Bernt Hansen
2011-10-23 22:50             ` Bernt Hansen
2011-10-26 16:07           ` Michael Brand [this message]
2011-10-26 16:56             ` Achim Gratz
2011-10-27 18:24               ` Michael Brand
2011-10-28  9:26                 ` Achim Gratz
2011-10-29 11:40                   ` Michael Brand
2011-10-30  7:01                     ` Achim Gratz
2011-10-30 14:20                       ` Michael Brand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALn3zogQ0NB-WoNuQZaPjJyBvvkJE_pr-dcjhX5KJUtGxQV=Aw@mail.gmail.com' \
    --to=michael.ch.brand@gmail.com \
    --cc=bernt@norang.ca \
    --cc=bzg@altern.org \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).