emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Michael Brand <michael.ch.brand@gmail.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: "git describe" in version of info file with "make info_git_describe"
Date: Sat, 29 Oct 2011 13:40:53 +0200	[thread overview]
Message-ID: <CALn3zojd61JJ+b1EkxnDG1gDx024Gui--E5ZjHzDsQU_TqQ7mw@mail.gmail.com> (raw)
In-Reply-To: <87fwidpiut.fsf@Rainer.invalid>

Hi Achim

On Fri, Oct 28, 2011 at 11:26, Achim Gratz <Stromeko@nexgo.de> wrote:
> Again I don't know if or when this gets merged.  I've already used up my
> TINYCHANGEs and hit an impasse with the FSF papers that I don't know how
> to resolve... :-(  Then again, the build system doesn't really become
> part of Emacs, but it's up to the maintainers to decide.

I hope that this can be solved and that your Makefile restructuring
will be merged into master.

> I'd much prefer to inject the version in a different way, not making an
> altered copy that the build works from.  The result is the same, but it
> doesn't feel OK... so probably the solution should be to get the version
> injected via some @set in an @include file (that's the recommended way
> from the Texinfo perspective, anyway) that is produced by make whenever
> the source file changes.

I prefer this cleaner solution you have just implemented too of course.

>> And I _added_ the target "info-vg" because implementing the same
>> functionality in the target "info" itself, by either adding an
>> auto-detect whether git describe is available (like org-version does)
>> or using org-version itself, is not an option. One still needs to have
>> the unchanged target "info" to build a release with the info version
>> not possibly influenced by git describe.
>
> I posit that if it's worth to have that (I'd say yes), ``make info´´
> should do that, in a way that is compatible with version control.

Is it possible with your current "make info" to get an info file
without git describe for a release like ELPA when made from within a
git repo and also for Emacs when building Emacs from a bzr-mirroring
git repo?

> Anyway, I've implemented the requested functionality into my Makefile
> fork, please test.

Thank you for this implementation. Since my patch discussed here is
now superseded by your branch I thought it would be cleaner to put my
comments to the sub-thread "Makefile restructuring" starting here:
http://lists.gnu.org/archive/html/emacs-orgmode/2011-07/msg00680.html

Michael

next prev parent reply	other threads:[~2011-10-29 11:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 14:11 "git describe" in version of info file with "make info_git_describe" Michael Brand
2011-06-02 14:47 ` Bernt Hansen
2011-06-02 15:05   ` Michael Brand
2011-06-02 19:36     ` Michael Brand
2011-10-16 19:12       ` Michael Brand
2011-10-21 14:44         ` Carsten Dominik
2011-10-21 16:13           ` Bernt Hansen
2011-10-23 22:50             ` Bernt Hansen
2011-10-26 16:07           ` Michael Brand
2011-10-26 16:56             ` Achim Gratz
2011-10-27 18:24               ` Michael Brand
2011-10-28  9:26                 ` Achim Gratz
2011-10-29 11:40                   ` Michael Brand [this message]
2011-10-30  7:01                     ` Achim Gratz
2011-10-30 14:20                       ` Michael Brand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALn3zojd61JJ+b1EkxnDG1gDx024Gui--E5ZjHzDsQU_TqQ7mw@mail.gmail.com \
    --to=michael.ch.brand@gmail.com \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).