emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Federico Beffa <beffa@ieee.org>
To: Rasmus <rasmus@gmx.us>,
	emacs-orgmode@gnu.org, Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] org.el: make org-paragraph-fill ignore \[...\] regions starting and ending a line
Date: Sat, 16 Aug 2014 09:50:07 +0200	[thread overview]
Message-ID: <CAKrPhPN2Wa6pS4voukxQfRn=M0co-77OFvzHLQZR1eY-kBrgdQ@mail.gmail.com> (raw)
In-Reply-To: <87lhqubvtd.fsf@nicolasgoaziou.fr>

On Mon, Aug 11, 2014 at 10:44 PM, Nicolas Goaziou
<mail@nicolasgoaziou.fr> wrote:
> Rasmus <rasmus@gmx.us> writes:
>
>> How about adding the possibility to add hooks to org-fill-paragraph?
>> So that people can add "extensions" to fill as they want and the core
>> function can rely on org-element only?
>
> You can `defadvice' anything to your heart's content.
>

From the elisp manual:
"...   Advising a function can cause confusion in debugging, since people
who debug calls to the original function may not notice that it has
been modified with advice.  Therefore, if you have the possibility to
change the code of that function to run a hook, please solve the
problem that way.  ..."

Given that people have different opinions on this, a hook would
actually be a good idea. It would give more freedom to the users.
Isn't this the goal of the GNU project :-)

Regards,
Fede

  reply	other threads:[~2014-08-16  7:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-10 13:13 [PATCH] org.el: make org-paragraph-fill ignore \[...\] regions starting and ending a line Federico Beffa
2014-08-11 13:06 ` Nicolas Goaziou
2014-08-11 18:27   ` Federico Beffa
2014-08-11 19:43     ` Rasmus
2014-08-11 20:44       ` Nicolas Goaziou
2014-08-16  7:50         ` Federico Beffa [this message]
2014-08-16  9:46           ` Nicolas Goaziou
2014-08-11 20:40     ` Nicolas Goaziou
2014-08-16  7:38       ` Federico Beffa
2014-08-28 10:10         ` Nicolas Goaziou
  -- strict thread matches above, loose matches on Subject: below --
2014-08-10 13:15 Federico Beffa
2014-08-07 13:56 Federico Beffa
2014-08-05 21:45 Federico Beffa
2014-08-09  8:00 ` Nicolas Goaziou
2014-08-09 10:20   ` Federico Beffa
2014-08-09 23:20     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKrPhPN2Wa6pS4voukxQfRn=M0co-77OFvzHLQZR1eY-kBrgdQ@mail.gmail.com' \
    --to=beffa@ieee.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).