[PATCH] org-mouse: Fix incorrect replacement for checkbox lists

[PATCH] org-mouse: Fix incorrect replacement for checkbox lists

[Ilya Zonov]

[-- Attachment #1.1: Type: text/plain, Size: 305 bytes --]

Hi,

I have prepared patch which fixes incorrect replacement with org-mouse
popup function for checkbox lists: "All Set" and "All Clear". Please, check
it. See attachment.

-- 
*Илья Зонов* (*Ilya Zonov*) aka *puzan*
Нижний Новгород, Россия (Nizhny Novgorod, Russia)

[-- Attachment #1.2: Type: text/html, Size: 475 bytes --]

[-- Attachment #2: 0001-org-mouse-Fix-incorrect-replacement-for-checkbox-lis.patch --]
[-- Type: application/octet-stream, Size: 1131 bytes --]

From d41656bc737043776bb5d5b4c5c9ae4e560ad3c0 Mon Sep 17 00:00:00 2001
From: Ilya Zonov <izonov@gmail.com>
Date: Fri, 24 May 2013 21:10:38 +0400
Subject: [PATCH] org-mouse: Fix incorrect replacement for checkbox lists

* org-mode: Add correct newtext parameter in `org-mouse-context-menu'
  function for "All Set" and "All Clear" menu items.
---
 lisp/org-mouse.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org-mouse.el b/lisp/org-mouse.el
index fbdc7fb..c8a6c86 100644
--- a/lisp/org-mouse.el
+++ b/lisp/org-mouse.el
@@ -656,11 +656,11 @@ This means, between the beginning of line and the point."
 	 ["All Clear" (org-mouse-for-each-item
 		       (lambda ()
 			 (when (save-excursion (org-at-item-checkbox-p))
-			   (replace-match "[ ]"))))]
+			   (replace-match "[ ] "))))]
 	 ["All Set" (org-mouse-for-each-item
 		     (lambda ()
 		       (when (save-excursion (org-at-item-checkbox-p))
-			 (replace-match "[X]"))))]
+			 (replace-match "[X] "))))]
 	 ["All Toggle" (org-mouse-for-each-item 'org-toggle-checkbox) t]
 	 ["All Remove" (org-mouse-for-each-item
 			(lambda ()
-- 
1.8.2.3

Re: [PATCH] org-mouse: Fix incorrect replacement for checkbox lists

[Bastien]

Hi Ilya,

Ilya Zonov <izonov@gmail.com> writes:

> I have prepared patch which fixes incorrect replacement with
> org-mouse popup function for checkbox lists: "All Set" and "All
> Clear". Please, check it. See attachment.

Applied, thanks.

Please add TINYCHANGE at the end of your commit message for such
changes next time, it helps us keep track of what does not need
a copyright assignment.

Thanks!

-- 
 Bastien