* [PATCH] org-mouse: Fix incorrect replacement for checkbox lists
@ 2013-05-24 17:51 Ilya Zonov
2013-06-27 15:38 ` Bastien
0 siblings, 1 reply; 2+ messages in thread
From: Ilya Zonov @ 2013-05-24 17:51 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1.1: Type: text/plain, Size: 305 bytes --]
Hi,
I have prepared patch which fixes incorrect replacement with org-mouse
popup function for checkbox lists: "All Set" and "All Clear". Please, check
it. See attachment.
--
*Илья Зонов* (*Ilya Zonov*) aka *puzan*
Нижний Новгород, Россия (Nizhny Novgorod, Russia)
[-- Attachment #1.2: Type: text/html, Size: 475 bytes --]
[-- Attachment #2: 0001-org-mouse-Fix-incorrect-replacement-for-checkbox-lis.patch --]
[-- Type: application/octet-stream, Size: 1131 bytes --]
From d41656bc737043776bb5d5b4c5c9ae4e560ad3c0 Mon Sep 17 00:00:00 2001
From: Ilya Zonov <izonov@gmail.com>
Date: Fri, 24 May 2013 21:10:38 +0400
Subject: [PATCH] org-mouse: Fix incorrect replacement for checkbox lists
* org-mode: Add correct newtext parameter in `org-mouse-context-menu'
function for "All Set" and "All Clear" menu items.
---
lisp/org-mouse.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/org-mouse.el b/lisp/org-mouse.el
index fbdc7fb..c8a6c86 100644
--- a/lisp/org-mouse.el
+++ b/lisp/org-mouse.el
@@ -656,11 +656,11 @@ This means, between the beginning of line and the point."
["All Clear" (org-mouse-for-each-item
(lambda ()
(when (save-excursion (org-at-item-checkbox-p))
- (replace-match "[ ]"))))]
+ (replace-match "[ ] "))))]
["All Set" (org-mouse-for-each-item
(lambda ()
(when (save-excursion (org-at-item-checkbox-p))
- (replace-match "[X]"))))]
+ (replace-match "[X] "))))]
["All Toggle" (org-mouse-for-each-item 'org-toggle-checkbox) t]
["All Remove" (org-mouse-for-each-item
(lambda ()
--
1.8.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] org-mouse: Fix incorrect replacement for checkbox lists
2013-05-24 17:51 [PATCH] org-mouse: Fix incorrect replacement for checkbox lists Ilya Zonov
@ 2013-06-27 15:38 ` Bastien
0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2013-06-27 15:38 UTC (permalink / raw)
To: Ilya Zonov; +Cc: emacs-orgmode
Hi Ilya,
Ilya Zonov <izonov@gmail.com> writes:
> I have prepared patch which fixes incorrect replacement with
> org-mouse popup function for checkbox lists: "All Set" and "All
> Clear". Please, check it. See attachment.
Applied, thanks.
Please add TINYCHANGE at the end of your commit message for such
changes next time, it helps us keep track of what does not need
a copyright assignment.
Thanks!
--
Bastien
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-27 15:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-24 17:51 [PATCH] org-mouse: Fix incorrect replacement for checkbox lists Ilya Zonov
2013-06-27 15:38 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).