emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ilya Zonov <izonov@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] org-mouse: Fix incorrect replacement for checkbox lists
Date: Fri, 24 May 2013 21:51:43 +0400	[thread overview]
Message-ID: <CAHAVt8cQU85_52G85Ax18=DoQw0GcgY_e9as08thXoHnf0mHig@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 305 bytes --]

Hi,

I have prepared patch which fixes incorrect replacement with org-mouse
popup function for checkbox lists: "All Set" and "All Clear". Please, check
it. See attachment.

-- 
*Илья Зонов* (*Ilya Zonov*) aka *puzan*
Нижний Новгород, Россия (Nizhny Novgorod, Russia)

[-- Attachment #1.2: Type: text/html, Size: 475 bytes --]

[-- Attachment #2: 0001-org-mouse-Fix-incorrect-replacement-for-checkbox-lis.patch --]
[-- Type: application/octet-stream, Size: 1131 bytes --]

From d41656bc737043776bb5d5b4c5c9ae4e560ad3c0 Mon Sep 17 00:00:00 2001
From: Ilya Zonov <izonov@gmail.com>
Date: Fri, 24 May 2013 21:10:38 +0400
Subject: [PATCH] org-mouse: Fix incorrect replacement for checkbox lists

* org-mode: Add correct newtext parameter in `org-mouse-context-menu'
  function for "All Set" and "All Clear" menu items.
---
 lisp/org-mouse.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/org-mouse.el b/lisp/org-mouse.el
index fbdc7fb..c8a6c86 100644
--- a/lisp/org-mouse.el
+++ b/lisp/org-mouse.el
@@ -656,11 +656,11 @@ This means, between the beginning of line and the point."
 	 ["All Clear" (org-mouse-for-each-item
 		       (lambda ()
 			 (when (save-excursion (org-at-item-checkbox-p))
-			   (replace-match "[ ]"))))]
+			   (replace-match "[ ] "))))]
 	 ["All Set" (org-mouse-for-each-item
 		     (lambda ()
 		       (when (save-excursion (org-at-item-checkbox-p))
-			 (replace-match "[X]"))))]
+			 (replace-match "[X] "))))]
 	 ["All Toggle" (org-mouse-for-each-item 'org-toggle-checkbox) t]
 	 ["All Remove" (org-mouse-for-each-item
 			(lambda ()
-- 
1.8.2.3

next             reply	other threads:[~2013-05-24 17:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24 17:51 Ilya Zonov [this message]
2013-06-27 15:38 ` [PATCH] org-mouse: Fix incorrect replacement for checkbox lists Bastien

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:fbdc7fb dfblob:c8a6c86
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHAVt8cQU85_52G85Ax18=DoQw0GcgY_e9as08thXoHnf0mHig@mail.gmail.com' \
    --to=izonov@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).