* BUG: swapped utf-8 symbols in org-entities @ 2016-06-28 8:15 Konstantin Kliakhandler 2016-06-28 14:49 ` Nicolas Goaziou 2016-06-28 19:21 ` Rasmus 0 siblings, 2 replies; 14+ messages in thread From: Konstantin Kliakhandler @ 2016-06-28 8:15 UTC (permalink / raw) To: emacs-orgmode [-- Attachment #1: Type: text/plain, Size: 934 bytes --] Hello, The unicode letters for 'varphi' and for 'phi' are swapped. Here is a patch correcting this: diff --git a/lisp/org-entities.el b/lisp/org-entities.el index 4044432..6f6d054 100644 --- a/lisp/org-entities.el +++ b/lisp/org-entities.el @@ -204,9 +204,8 @@ packages to be loaded, add these packages to `org-latex-packages-alist'." ("upsih" "\\Upsilon" t "ϒ" "upsilon" "upsilon" "ϒ") ("upsilon" "\\upsilon" t "υ" "upsilon" "upsilon" "υ") ("Phi" "\\Phi" t "Φ" "Phi" "Phi" "Φ") - ("phi" "\\phi" t "φ" "phi" "phi" "φ") - ("varphi" "\\varphi" t "ϕ" "varphi" "varphi" "ɸ") + ("phi" "\\phi" t "φ" "phi" "phi" "ɸ") + ("varphi" "\\varphi" t "ϕ" "varphi" "varphi" "φ") ("Chi" "X" nil "Χ" "Chi" "Chi" "Χ") ("chi" "\\chi" t "χ" "chi" "chi" "χ") ("acutex" "\\acute x" t "´x" "'x" "'x" "𝑥́") Thanks, Kosta [-- Attachment #2: Type: text/html, Size: 2324 bytes --] ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-06-28 8:15 BUG: swapped utf-8 symbols in org-entities Konstantin Kliakhandler @ 2016-06-28 14:49 ` Nicolas Goaziou 2016-06-30 14:33 ` Konstantin Kliakhandler 2016-06-28 19:21 ` Rasmus 1 sibling, 1 reply; 14+ messages in thread From: Nicolas Goaziou @ 2016-06-28 14:49 UTC (permalink / raw) To: Konstantin Kliakhandler; +Cc: emacs-orgmode Hello, Konstantin Kliakhandler <kosta@slumpy.org> writes: > The unicode letters for 'varphi' and for 'phi' are swapped. Good catch. > Here is a patch correcting this: Would you mind providing a patch with a proper commit message and using git format-patch? See <http://orgmode.org/worg/org-contribute.html#patches> for details. Thank you. Regards, -- Nicolas Goaziou ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-06-28 14:49 ` Nicolas Goaziou @ 2016-06-30 14:33 ` Konstantin Kliakhandler 2016-07-01 7:24 ` Nicolas Goaziou 0 siblings, 1 reply; 14+ messages in thread From: Konstantin Kliakhandler @ 2016-06-30 14:33 UTC (permalink / raw) To: Konstantin Kliakhandler, emacs-orgmode [-- Attachment #1.1: Type: text/plain, Size: 879 bytes --] Hello Nicolas, Attached is the patch, as requested. I'm not sure what were the conclusions of the side discussion, but I do want to point out that my change is in accordance with unicode symbol names and with the symbols that pdflatex prints on paper. Thanks and regards, Kosta -- Konstantin Kliakhandler http://slumpy.org )°) )°( (°( On 28 June 2016 at 17:49, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote: > Hello, > > Konstantin Kliakhandler <kosta@slumpy.org> writes: > > > The unicode letters for 'varphi' and for 'phi' are swapped. > > Good catch. > > > Here is a patch correcting this: > > Would you mind providing a patch with a proper commit message and using > git format-patch? See > <http://orgmode.org/worg/org-contribute.html#patches> for details. > > Thank you. > > Regards, > > -- > Nicolas Goaziou > [-- Attachment #1.2: Type: text/html, Size: 1720 bytes --] [-- Attachment #2: 0001-org-entities.el-swapped-symbols-of-varphi-and-phi.patch --] [-- Type: application/octet-stream, Size: 1235 bytes --] From e321b043461aa3222b00729b93626f15c602b2c8 Mon Sep 17 00:00:00 2001 From: Konstantin Kliakhandler <kosta@slumpy.org> Date: Thu, 30 Jun 2016 17:13:21 +0300 Subject: [PATCH] org-entities.el: swapped symbols of varphi and phi * org-entities.el (`org-entities'): Swap the unicode symbol of phi and of varphi. TINYCHANGE --- lisp/org-entities.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/org-entities.el b/lisp/org-entities.el index dec5064..36dfbd2 100644 --- a/lisp/org-entities.el +++ b/lisp/org-entities.el @@ -203,8 +203,8 @@ packages to be loaded, add these packages to `org-latex-packages-alist'." ("upsih" "\\Upsilon" t "ϒ" "upsilon" "upsilon" "ϒ") ("upsilon" "\\upsilon" t "υ" "upsilon" "upsilon" "υ") ("Phi" "\\Phi" t "Φ" "Phi" "Phi" "Φ") - ("phi" "\\phi" t "φ" "phi" "phi" "φ") - ("varphi" "\\varphi" t "ϕ" "varphi" "varphi" "ɸ") + ("phi" "\\phi" t "φ" "phi" "phi" "ɸ") + ("varphi" "\\varphi" t "ϕ" "varphi" "varphi" "φ") ("Chi" "X" nil "Χ" "Chi" "Chi" "Χ") ("chi" "\\chi" t "χ" "chi" "chi" "χ") ("acutex" "\\acute x" t "´x" "'x" "'x" "𝑥́") -- 2.7.4 (Apple Git-66) ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-06-30 14:33 ` Konstantin Kliakhandler @ 2016-07-01 7:24 ` Nicolas Goaziou 2016-07-03 11:47 ` Konstantin Kliakhandler 2016-07-06 11:18 ` Rasmus 0 siblings, 2 replies; 14+ messages in thread From: Nicolas Goaziou @ 2016-07-01 7:24 UTC (permalink / raw) To: Konstantin Kliakhandler; +Cc: emacs-orgmode, Rasmus Hello, Konstantin Kliakhandler <kosta@slumpy.org> writes: > Attached is the patch, as requested. Applied. Thank you. > I'm not sure what were the conclusions of the side discussion, but > I do want to point out that my change is in accordance with unicode > symbol names and with the symbols that pdflatex prints on paper. I think Rasmus (Cc'ed) discovered a bug in TeX input method. Rasmus, would you feel like reporting it upstream? Regards, -- Nicolas Goaziou ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-07-01 7:24 ` Nicolas Goaziou @ 2016-07-03 11:47 ` Konstantin Kliakhandler 2016-07-05 19:13 ` Nicolas Goaziou 2016-07-06 11:18 ` Rasmus 1 sibling, 1 reply; 14+ messages in thread From: Konstantin Kliakhandler @ 2016-07-03 11:47 UTC (permalink / raw) To: Konstantin Kliakhandler, emacs-orgmode, Rasmus [-- Attachment #1.1: Type: text/plain, Size: 907 bytes --] Thanks! I have an additional, similar patch - In this one I changed the unicode symbol for \circ from something looking like ^ to [image: \circ] (#x2218 = "ring operator" = \circ in TeX input method). Thanks, Kosta -- Konstantin Kliakhandler http://slumpy.org )°) )°( (°( On 1 July 2016 at 10:24, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote: > Hello, > > Konstantin Kliakhandler <kosta@slumpy.org> writes: > > > Attached is the patch, as requested. > > Applied. Thank you. > > > I'm not sure what were the conclusions of the side discussion, but > > I do want to point out that my change is in accordance with unicode > > symbol names and with the symbols that pdflatex prints on paper. > > I think Rasmus (Cc'ed) discovered a bug in TeX input method. Rasmus, > would you feel like reporting it upstream? > > Regards, > > -- > Nicolas Goaziou > [-- Attachment #1.2: Type: text/html, Size: 1850 bytes --] [-- Attachment #2: 0001-org-entities-Correct-unicode-symbol-of-circ.patch --] [-- Type: application/octet-stream, Size: 974 bytes --] From 2cb005c6344ae5d749a083f941bf24ce72fd5d80 Mon Sep 17 00:00:00 2001 From: Konstantin Kliakhandler <kosta@slumpy.org> Date: Sun, 3 Jul 2016 13:05:27 +0300 Subject: [PATCH] org-entities: Correct unicode symbol of circ * org-entities.el (org-entities): Change the unicode symbol of circ to "ring operator" (#x2218). TINYCHANGE --- lisp/org-entities.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-entities.el b/lisp/org-entities.el index 36dfbd2..bfaaec7 100644 --- a/lisp/org-entities.el +++ b/lisp/org-entities.el @@ -260,7 +260,7 @@ packages to be loaded, add these packages to `org-latex-packages-alist'." "* Other" "** Misc. (often used)" - ("circ" "\\^{}" nil "ˆ" "^" "^" "ˆ") + ("circ" "\\^{}" nil "ˆ" "^" "^" "∘") ("vert" "\\vert{}" t "|" "|" "|" "|") ("vbar" "|" nil "|" "|" "|" "|") ("brvbar" "\\textbrokenbar{}" nil "¦" "|" "¦" "¦") -- 2.7.4 (Apple Git-66) ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-07-03 11:47 ` Konstantin Kliakhandler @ 2016-07-05 19:13 ` Nicolas Goaziou 2016-08-29 12:26 ` Konstantin Kliakhandler 0 siblings, 1 reply; 14+ messages in thread From: Nicolas Goaziou @ 2016-07-05 19:13 UTC (permalink / raw) To: Konstantin Kliakhandler; +Cc: emacs-orgmode, Rasmus Hello, Konstantin Kliakhandler <kosta@slumpy.org> writes: > I have an additional, similar patch - In this one I changed the unicode > symbol for \circ from something looking like ^ to [image: \circ] (#x2218 = > "ring operator" = \circ in TeX input method). For some reason, I'm unable to apply it to maint branch. Could you rebase your repository and try again? Thank you. Regards, -- Nicolas Goaziou ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-07-05 19:13 ` Nicolas Goaziou @ 2016-08-29 12:26 ` Konstantin Kliakhandler 2016-08-30 9:54 ` Nicolas Goaziou 0 siblings, 1 reply; 14+ messages in thread From: Konstantin Kliakhandler @ 2016-08-29 12:26 UTC (permalink / raw) To: Konstantin Kliakhandler, emacs-orgmode, Rasmus [-- Attachment #1.1: Type: text/plain, Size: 1003 bytes --] Hi Nicolas, Sorry for the late reply. Am I supposed to send the patch against master or against maint? If against master, see the file starting at 0001. If against maint, see the file starting with 0002. For some reason, I can't apply the 0001 patch to the maint branch either, nor can I rebase it to the maint branch... Weird. Hopefully this is good enough. Best, Kosta -- Konstantin Kliakhandler http://slumpy.org )°) )°( (°( On 5 July 2016 at 22:13, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote: > Hello, > > Konstantin Kliakhandler <kosta@slumpy.org> writes: > > > I have an additional, similar patch - In this one I changed the unicode > > symbol for \circ from something looking like ^ to [image: \circ] (#x2218 > = > > "ring operator" = \circ in TeX input method). > > For some reason, I'm unable to apply it to maint branch. Could you > rebase your repository and try again? > > Thank you. > > Regards, > > -- > Nicolas Goaziou > [-- Attachment #1.2: Type: text/html, Size: 1741 bytes --] [-- Attachment #2: 0001-org-entities-Correct-unicode-symbol-of-circ.patch --] [-- Type: application/octet-stream, Size: 960 bytes --] From 1271324bd0e100aad1c4342ad51658e82be9e1d5 Mon Sep 17 00:00:00 2001 From: Konstantin Kliakhandler <kosta@slumpy.org> Date: Mon, 29 Aug 2016 15:07:21 +0300 Subject: [PATCH] org-entities: Correct unicode symbol of circ * org-entities.el (org-entities): Change the unicode symbol of circ to "ring operator" (#x2218). TINYCHANGE --- lisp/org-entities.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-entities.el b/lisp/org-entities.el index e5c9845..7ef0524 100644 --- a/lisp/org-entities.el +++ b/lisp/org-entities.el @@ -260,7 +260,7 @@ packages to be loaded, add these packages to `org-latex-packages-alist'." "* Other" "** Misc. (often used)" - ("circ" "\\^{}" nil "ˆ" "^" "^" "ˆ") + ("circ" "\\^{}" nil "ˆ" "^" "^" "∘") ("vert" "\\vert{}" t "|" "|" "|" "|") ("vbar" "|" nil "|" "|" "|" "|") ("brvbar" "\\textbrokenbar{}" nil "¦" "|" "¦" "¦") -- 2.8.1 [-- Attachment #3: 0002-org-entities-Correct-unicode-symbol-of-circ.patch --] [-- Type: application/octet-stream, Size: 974 bytes --] From dbda08c67c540d5bb839e6a8ece619551f4283e7 Mon Sep 17 00:00:00 2001 From: Konstantin Kliakhandler <kosta@slumpy.org> Date: Mon, 29 Aug 2016 15:23:11 +0300 Subject: [PATCH] org-entities: Correct unicode symbol of circ * org-entities.el (org-entities): Change the unicode symbol of circ to "ring operator" (#x2218). TINYCHANGE --- lisp/org-entities.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-entities.el b/lisp/org-entities.el index ccac29a..b00eec8 100644 --- a/lisp/org-entities.el +++ b/lisp/org-entities.el @@ -265,7 +265,7 @@ packages to be loaded, add these packages to `org-latex-packages-alist'." "* Other" "** Misc. (often used)" - ("circ" "\\^{}" nil "ˆ" "^" "^" "ˆ") + ("circ" "\\^{}" nil "ˆ" "^" "^" "∘") ("vert" "\\vert{}" t "|" "|" "|" "|") ("brvbar" "\\textbrokenbar{}" nil "¦" "|" "¦" "¦") ("S" "\\S" nil "§" "paragraph" "§" "§") -- 2.8.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-08-29 12:26 ` Konstantin Kliakhandler @ 2016-08-30 9:54 ` Nicolas Goaziou 0 siblings, 0 replies; 14+ messages in thread From: Nicolas Goaziou @ 2016-08-30 9:54 UTC (permalink / raw) To: Konstantin Kliakhandler; +Cc: emacs-orgmode, Rasmus Hello, Konstantin Kliakhandler <kosta@slumpy.org> writes: > Sorry for the late reply. Am I supposed to send the patch against master or > against maint? The latter. Applied. Thank you. Regards, -- Nicolas Goaziou ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-07-01 7:24 ` Nicolas Goaziou 2016-07-03 11:47 ` Konstantin Kliakhandler @ 2016-07-06 11:18 ` Rasmus 2016-07-06 13:10 ` Nicolas Goaziou 1 sibling, 1 reply; 14+ messages in thread From: Rasmus @ 2016-07-06 11:18 UTC (permalink / raw) To: emacs-orgmode Nicolas Goaziou <mail@nicolasgoaziou.fr> writes: >> I'm not sure what were the conclusions of the side discussion, but >> I do want to point out that my change is in accordance with unicode >> symbol names and with the symbols that pdflatex prints on paper. > > I think Rasmus (Cc'ed) discovered a bug in TeX input method. Rasmus, > would you feel like reporting it upstream? Sure, I can do that. Rasmus -- Slowly unravels in a ball of yarn and the devil collects it ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-07-06 11:18 ` Rasmus @ 2016-07-06 13:10 ` Nicolas Goaziou 0 siblings, 0 replies; 14+ messages in thread From: Nicolas Goaziou @ 2016-07-06 13:10 UTC (permalink / raw) To: Rasmus; +Cc: emacs-orgmode Hello, Rasmus <rasmus@gmx.us> writes: > Sure, I can do that. Thanks ! Regards, -- Nicolas Goaziou ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-06-28 8:15 BUG: swapped utf-8 symbols in org-entities Konstantin Kliakhandler 2016-06-28 14:49 ` Nicolas Goaziou @ 2016-06-28 19:21 ` Rasmus 2016-06-28 19:58 ` Nicolas Goaziou 2016-06-28 20:10 ` Nick Dokos 1 sibling, 2 replies; 14+ messages in thread From: Rasmus @ 2016-06-28 19:21 UTC (permalink / raw) To: emacs-orgmode Konstantin Kliakhandler <kosta@slumpy.org> writes: > Hello, > > The unicode letters for 'varphi' and for 'phi' are swapped. > > Here is a patch correcting this: > > diff --git a/lisp/org-entities.el b/lisp/org-entities.el > index 4044432..6f6d054 100644 > --- a/lisp/org-entities.el > +++ b/lisp/org-entities.el > @@ -204,9 +204,8 @@ packages to be loaded, add these packages to > `org-latex-packages-alist'." > ("upsih" "\\Upsilon" t "ϒ" "upsilon" "upsilon" "ϒ") > ("upsilon" "\\upsilon" t "υ" "upsilon" "upsilon" "υ") > ("Phi" "\\Phi" t "Φ" "Phi" "Phi" "Φ") > - ("phi" "\\phi" t "φ" "phi" "phi" "φ") > - ("varphi" "\\varphi" t "ϕ" "varphi" "varphi" "ɸ") > + ("phi" "\\phi" t "φ" "phi" "phi" "ɸ") > + ("varphi" "\\varphi" t "ϕ" "varphi" "varphi" "φ") It's not straight forward. The behavior is "correct" with reference to (La)TeX. E.g. M-x set-input-method RET TeX RET Then, \phi → φ \varphi → ϕ Your suggestion is correct with reference to HTML. I’d tend to favor the TeX interpretation even if it’s technically wrong. Rasmus -- May contains speling mistake ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-06-28 19:21 ` Rasmus @ 2016-06-28 19:58 ` Nicolas Goaziou 2016-06-28 20:30 ` Rasmus 2016-06-28 20:10 ` Nick Dokos 1 sibling, 1 reply; 14+ messages in thread From: Nicolas Goaziou @ 2016-06-28 19:58 UTC (permalink / raw) To: Rasmus; +Cc: emacs-orgmode Hello, Rasmus <rasmus@gmx.us> writes: > The behavior is "correct" with reference to (La)TeX. E.g. > > M-x set-input-method RET TeX RET > > Then, > > \phi → φ > \varphi → ϕ > > Your suggestion is correct with reference to HTML. > > I’d tend to favor the TeX interpretation even if it’s technically > wrong. AFAICT, (La)TeX disagrees with TeX input method. The latter may be buggy. Regards, -- Nicolas Goaziou ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-06-28 19:58 ` Nicolas Goaziou @ 2016-06-28 20:30 ` Rasmus 0 siblings, 0 replies; 14+ messages in thread From: Rasmus @ 2016-06-28 20:30 UTC (permalink / raw) To: emacs-orgmode > AFAICT, (La)TeX disagrees with TeX input method. The latter may be > buggy. > > Regards, Nick Dokos <ndokos@gmail.com> writes: > That's not what Lamport says (p.41, 2nd ed.) Maybe the input method > got it wrong? Oh, you are all right. Sorry about the noise. -- You people at the NSA are becoming my new best friends! ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: BUG: swapped utf-8 symbols in org-entities 2016-06-28 19:21 ` Rasmus 2016-06-28 19:58 ` Nicolas Goaziou @ 2016-06-28 20:10 ` Nick Dokos 1 sibling, 0 replies; 14+ messages in thread From: Nick Dokos @ 2016-06-28 20:10 UTC (permalink / raw) To: emacs-orgmode Rasmus <rasmus@gmx.us> writes: > Konstantin Kliakhandler <kosta@slumpy.org> writes: > >> Hello, >> >> The unicode letters for 'varphi' and for 'phi' are swapped. >> >> Here is a patch correcting this: >> >> diff --git a/lisp/org-entities.el b/lisp/org-entities.el >> index 4044432..6f6d054 100644 >> --- a/lisp/org-entities.el >> +++ b/lisp/org-entities.el >> @@ -204,9 +204,8 @@ packages to be loaded, add these packages to >> `org-latex-packages-alist'." >> ("upsih" "\\Upsilon" t "ϒ" "upsilon" "upsilon" "ϒ") >> ("upsilon" "\\upsilon" t "υ" "upsilon" "upsilon" "υ") >> ("Phi" "\\Phi" t "Φ" "Phi" "Phi" "Φ") >> - ("phi" "\\phi" t "φ" "phi" "phi" "φ") >> - ("varphi" "\\varphi" t "ϕ" "varphi" "varphi" "ɸ") >> + ("phi" "\\phi" t "φ" "phi" "phi" "ɸ") >> + ("varphi" "\\varphi" t "ϕ" "varphi" "varphi" "φ") > > It's not straight forward. > > The behavior is "correct" with reference to (La)TeX. E.g. > > M-x set-input-method RET TeX RET > > Then, > > \phi → φ > \varphi → ϕ > That's not what Lamport says (p.41, 2nd ed.) Maybe the input method got it wrong? > Your suggestion is correct with reference to HTML. > > I’d tend to favor the TeX interpretation even if it’s technically wrong. > > Rasmus -- Nick ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-08-30 9:54 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-06-28 8:15 BUG: swapped utf-8 symbols in org-entities Konstantin Kliakhandler 2016-06-28 14:49 ` Nicolas Goaziou 2016-06-30 14:33 ` Konstantin Kliakhandler 2016-07-01 7:24 ` Nicolas Goaziou 2016-07-03 11:47 ` Konstantin Kliakhandler 2016-07-05 19:13 ` Nicolas Goaziou 2016-08-29 12:26 ` Konstantin Kliakhandler 2016-08-30 9:54 ` Nicolas Goaziou 2016-07-06 11:18 ` Rasmus 2016-07-06 13:10 ` Nicolas Goaziou 2016-06-28 19:21 ` Rasmus 2016-06-28 19:58 ` Nicolas Goaziou 2016-06-28 20:30 ` Rasmus 2016-06-28 20:10 ` Nick Dokos
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).