bug#38592: 27.0.50; org mode insinuates itself into calendar

bug#38592: 27.0.50; org mode insinuates itself into calendar

[Bastien]

Eli Zaretskii <eliz@gnu.org> writes:

> So I think you should report this to Org developers first, because it
> sounds like an Org bug.

I suspect org-compat.el was loaded by some lingering installation of Org.

Sam, do you still get this bug?

-- 
 Bastien

bug#38592: 27.0.50; org mode insinuates itself into calendar

[Sam Steingold]

Yes, I still have to (remove-hook 'calendar-mode-hook
'org--setup-calendar-bindings) manually

On Thu, 13 Feb 2020 at 03:43, Bastien <bzg@gnu.org> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > So I think you should report this to Org developers first, because it
> > sounds like an Org bug.
>
> I suspect org-compat.el was loaded by some lingering installation of Org.
>
> Sam, do you still get this bug?
>
> --
>  Bastien



-- 
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>

bug#38592: 27.0.50; org mode insinuates itself into calendar

[Bastien]

Hi Sam,

Sam Steingold <sds@gnu.org> writes:

> Yes, I still have to (remove-hook 'calendar-mode-hook
> 'org--setup-calendar-bindings) manually

The hook is not added until Org is loaded -- can you track down
why org-mode gets loaded?

-- 
 Bastien

bug#38592: 27.0.50; org mode insinuates itself into calendar

[Sam Steingold]

Hi Bastien,

If you tell me what to do, I would gladly do it.
I am afraid I am too busy to investigate it myself...
sorry

On Thu, 13 Feb 2020 at 10:41, Bastien <bzg@gnu.org> wrote:
>
> Hi Sam,
>
> Sam Steingold <sds@gnu.org> writes:
>
> > Yes, I still have to (remove-hook 'calendar-mode-hook
> > 'org--setup-calendar-bindings) manually
>
> The hook is not added until Org is loaded -- can you track down
> why org-mode gets loaded?
>
> --
>  Bastien



-- 
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>

bug#38592: 27.0.50; org mode insinuates itself into calendar

[Bastien]

Hi Sam,

Sam Steingold <sds@gnu.org> writes:

> If you tell me what to do, I would gladly do it.
> I am afraid I am too busy to investigate it myself...

if you can share your .emacs file (removing private information)
I can try to bisect and find what causes Org to be loaded: you can
send it to me in private if you prefer.

But in the meantime, I confirm that with Emacs -q (from latest
master), Org is *not* loaded and calendar-mode-hook is nil.

Best,

-- 
 Bastien

bug#38592: 27.0.50; org mode insinuates itself into calendar

[Sam Steingold]

Looks like a bug in ein,
https://github.com/millejoh/emacs-ipython-notebook/issues/668

On Fri, 14 Feb 2020 at 05:03, Bastien <bzg@gnu.org> wrote:
>
> Hi Sam,
>
> Sam Steingold <sds@gnu.org> writes:
>
> > If you tell me what to do, I would gladly do it.
> > I am afraid I am too busy to investigate it myself...
>
> if you can share your .emacs file (removing private information)
> I can try to bisect and find what causes Org to be loaded: you can
> send it to me in private if you prefer.
>
> But in the meantime, I confirm that with Emacs -q (from latest
> master), Org is *not* loaded and calendar-mode-hook is nil.
>
> Best,
>
> --
>  Bastien



-- 
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>

bug#38592: 27.0.50; org mode insinuates itself into calendar

[Bastien]

Hi Sam,

Sam Steingold <sds@gnu.org> writes:

> Looks like a bug in ein,
> https://github.com/millejoh/emacs-ipython-notebook/issues/668

Thanks for the follow-up.

I looked at ein-notebooklist.el a bit, where I could not understand
why logging in would call org--setup-calendar-bindings but I don't
know ein and cannot go further.

Feel free to close the bug report when you think it is resolved.

-- 
 Bastien

bug#38592: 27.0.50; org mode insinuates itself into calendar

[Sam Steingold]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

To reproduce:

emacs -Q -f package-initialize --eval "(require 'ob)" --eval "(and (cl-assert (featurep 'ob)) (cl-assert (not (featurep 'org))))" --eval "(call-interactively 'calendar)"

The emacs needs to be at least 165f738382.

How about, minimally:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 559 bytes --]

diff --git a/lisp/org/org-compat.el b/lisp/org/org-compat.el
index 4446a169d7..ea66bb82be 100644
--- a/lisp/org/org-compat.el
+++ b/lisp/org/org-compat.el
@@ -1043,7 +1043,7 @@ org--setup-calendar-bindings
     ((guard (not (lookup-key calendar-mode-map "c")))
      (local-set-key "c" #'org-calendar-goto-agenda))
     (_ nil))
-  (unless (eq org-agenda-diary-file 'diary-file)
+  (unless (and (boundp 'org-agenda-diary-file) (eq org-agenda-diary-file 'diary-file))
     (local-set-key org-calendar-insert-diary-entry-key
 		   #'org-agenda-diary-entry)))
 

[-- Attachment #3: Type: text/plain, Size: 82 bytes --]


I suspect other assumptions are made that `ob` cannot be required without `org`.

bug#38592: 27.0.50; org mode insinuates itself into calendar

[Bastien]

Hi Sam,

Sam Steingold <dick.r.chiang@gmail.com> writes:

> emacs -Q -f package-initialize --eval "(require 'ob)" --eval "(and
> (cl-assert (featurep 'ob)) (cl-assert (not (featurep 'org))))" --eval
> "(call-interactively 'calendar)"

OK, I understand now, thanks for the reproducible recipe.

> How about, minimally:

I added another fix (in Org's maint branch, the one that will be
released soon and sync with Emacs): requiring 'org-agenda whenever
both org-compat.el and calendar are loaded.

Thanks for reporting this, I'll close the bug when upstream Org is
merged into Emacs and you can confirm the fix.

Best,

-- 
 Bastien