* bug#38592: 27.0.50; org mode insinuates itself into calendar
[not found] ` <83sglo70fu.fsf@gnu.org>
@ 2020-02-13 8:43 ` Bastien
2020-02-13 14:31 ` Sam Steingold
0 siblings, 1 reply; 9+ messages in thread
From: Bastien @ 2020-02-13 8:43 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: sds, 38592
Eli Zaretskii <eliz@gnu.org> writes:
> So I think you should report this to Org developers first, because it
> sounds like an Org bug.
I suspect org-compat.el was loaded by some lingering installation of Org.
Sam, do you still get this bug?
--
Bastien
^ permalink raw reply [flat|nested] 9+ messages in thread* bug#38592: 27.0.50; org mode insinuates itself into calendar
2020-02-13 8:43 ` bug#38592: 27.0.50; org mode insinuates itself into calendar Bastien
@ 2020-02-13 14:31 ` Sam Steingold
2020-02-13 15:40 ` Bastien
0 siblings, 1 reply; 9+ messages in thread
From: Sam Steingold @ 2020-02-13 14:31 UTC (permalink / raw)
To: Bastien; +Cc: Eli Zaretskii, 38592
Yes, I still have to (remove-hook 'calendar-mode-hook
'org--setup-calendar-bindings) manually
On Thu, 13 Feb 2020 at 03:43, Bastien <bzg@gnu.org> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > So I think you should report this to Org developers first, because it
> > sounds like an Org bug.
>
> I suspect org-compat.el was loaded by some lingering installation of Org.
>
> Sam, do you still get this bug?
>
> --
> Bastien
--
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38592: 27.0.50; org mode insinuates itself into calendar
2020-02-13 14:31 ` Sam Steingold
@ 2020-02-13 15:40 ` Bastien
2020-02-13 16:45 ` Sam Steingold
0 siblings, 1 reply; 9+ messages in thread
From: Bastien @ 2020-02-13 15:40 UTC (permalink / raw)
To: Sam Steingold; +Cc: Eli Zaretskii, 38592
Hi Sam,
Sam Steingold <sds@gnu.org> writes:
> Yes, I still have to (remove-hook 'calendar-mode-hook
> 'org--setup-calendar-bindings) manually
The hook is not added until Org is loaded -- can you track down
why org-mode gets loaded?
--
Bastien
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38592: 27.0.50; org mode insinuates itself into calendar
2020-02-13 15:40 ` Bastien
@ 2020-02-13 16:45 ` Sam Steingold
2020-02-14 10:02 ` Bastien
0 siblings, 1 reply; 9+ messages in thread
From: Sam Steingold @ 2020-02-13 16:45 UTC (permalink / raw)
To: Bastien; +Cc: Eli Zaretskii, 38592
Hi Bastien,
If you tell me what to do, I would gladly do it.
I am afraid I am too busy to investigate it myself...
sorry
On Thu, 13 Feb 2020 at 10:41, Bastien <bzg@gnu.org> wrote:
>
> Hi Sam,
>
> Sam Steingold <sds@gnu.org> writes:
>
> > Yes, I still have to (remove-hook 'calendar-mode-hook
> > 'org--setup-calendar-bindings) manually
>
> The hook is not added until Org is loaded -- can you track down
> why org-mode gets loaded?
>
> --
> Bastien
--
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38592: 27.0.50; org mode insinuates itself into calendar
2020-02-13 16:45 ` Sam Steingold
@ 2020-02-14 10:02 ` Bastien
2020-02-17 4:12 ` Sam Steingold
0 siblings, 1 reply; 9+ messages in thread
From: Bastien @ 2020-02-14 10:02 UTC (permalink / raw)
To: Sam Steingold; +Cc: Eli Zaretskii, 38592
Hi Sam,
Sam Steingold <sds@gnu.org> writes:
> If you tell me what to do, I would gladly do it.
> I am afraid I am too busy to investigate it myself...
if you can share your .emacs file (removing private information)
I can try to bisect and find what causes Org to be loaded: you can
send it to me in private if you prefer.
But in the meantime, I confirm that with Emacs -q (from latest
master), Org is *not* loaded and calendar-mode-hook is nil.
Best,
--
Bastien
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38592: 27.0.50; org mode insinuates itself into calendar
2020-02-14 10:02 ` Bastien
@ 2020-02-17 4:12 ` Sam Steingold
2020-02-17 7:43 ` Bastien
0 siblings, 1 reply; 9+ messages in thread
From: Sam Steingold @ 2020-02-17 4:12 UTC (permalink / raw)
To: Bastien; +Cc: Eli Zaretskii, 38592
Looks like a bug in ein,
https://github.com/millejoh/emacs-ipython-notebook/issues/668
On Fri, 14 Feb 2020 at 05:03, Bastien <bzg@gnu.org> wrote:
>
> Hi Sam,
>
> Sam Steingold <sds@gnu.org> writes:
>
> > If you tell me what to do, I would gladly do it.
> > I am afraid I am too busy to investigate it myself...
>
> if you can share your .emacs file (removing private information)
> I can try to bisect and find what causes Org to be loaded: you can
> send it to me in private if you prefer.
>
> But in the meantime, I confirm that with Emacs -q (from latest
> master), Org is *not* loaded and calendar-mode-hook is nil.
>
> Best,
>
> --
> Bastien
--
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38592: 27.0.50; org mode insinuates itself into calendar
2020-02-17 4:12 ` Sam Steingold
@ 2020-02-17 7:43 ` Bastien
2020-02-17 12:51 ` Sam Steingold
0 siblings, 1 reply; 9+ messages in thread
From: Bastien @ 2020-02-17 7:43 UTC (permalink / raw)
To: Sam Steingold; +Cc: Eli Zaretskii, 38592
Hi Sam,
Sam Steingold <sds@gnu.org> writes:
> Looks like a bug in ein,
> https://github.com/millejoh/emacs-ipython-notebook/issues/668
Thanks for the follow-up.
I looked at ein-notebooklist.el a bit, where I could not understand
why logging in would call org--setup-calendar-bindings but I don't
know ein and cannot go further.
Feel free to close the bug report when you think it is resolved.
--
Bastien
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#38592: 27.0.50; org mode insinuates itself into calendar
2020-02-17 7:43 ` Bastien
@ 2020-02-17 12:51 ` Sam Steingold
2020-02-17 13:54 ` Bastien
0 siblings, 1 reply; 9+ messages in thread
From: Sam Steingold @ 2020-02-17 12:51 UTC (permalink / raw)
To: Bastien; +Cc: Sam Steingold, 38592
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
To reproduce:
emacs -Q -f package-initialize --eval "(require 'ob)" --eval "(and (cl-assert (featurep 'ob)) (cl-assert (not (featurep 'org))))" --eval "(call-interactively 'calendar)"
The emacs needs to be at least 165f738382.
How about, minimally:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 559 bytes --]
diff --git a/lisp/org/org-compat.el b/lisp/org/org-compat.el
index 4446a169d7..ea66bb82be 100644
--- a/lisp/org/org-compat.el
+++ b/lisp/org/org-compat.el
@@ -1043,7 +1043,7 @@ org--setup-calendar-bindings
((guard (not (lookup-key calendar-mode-map "c")))
(local-set-key "c" #'org-calendar-goto-agenda))
(_ nil))
- (unless (eq org-agenda-diary-file 'diary-file)
+ (unless (and (boundp 'org-agenda-diary-file) (eq org-agenda-diary-file 'diary-file))
(local-set-key org-calendar-insert-diary-entry-key
#'org-agenda-diary-entry)))
[-- Attachment #3: Type: text/plain, Size: 82 bytes --]
I suspect other assumptions are made that `ob` cannot be required without `org`.
^ permalink raw reply related [flat|nested] 9+ messages in thread* bug#38592: 27.0.50; org mode insinuates itself into calendar
2020-02-17 12:51 ` Sam Steingold
@ 2020-02-17 13:54 ` Bastien
0 siblings, 0 replies; 9+ messages in thread
From: Bastien @ 2020-02-17 13:54 UTC (permalink / raw)
To: Sam Steingold; +Cc: Sam Steingold, 38592
Hi Sam,
Sam Steingold <dick.r.chiang@gmail.com> writes:
> emacs -Q -f package-initialize --eval "(require 'ob)" --eval "(and
> (cl-assert (featurep 'ob)) (cl-assert (not (featurep 'org))))" --eval
> "(call-interactively 'calendar)"
OK, I understand now, thanks for the reproducible recipe.
> How about, minimally:
I added another fix (in Org's maint branch, the one that will be
released soon and sync with Emacs): requiring 'org-agenda whenever
both org-compat.el and calendar are loaded.
Thanks for reporting this, I'll close the bug when upstream Org is
merged into Emacs and you can confirm the fix.
Best,
--
Bastien
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-02-17 13:55 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <m14ky4jpq7.fsf@gnu.org>
[not found] ` <83sglo70fu.fsf@gnu.org>
2020-02-13 8:43 ` bug#38592: 27.0.50; org mode insinuates itself into calendar Bastien
2020-02-13 14:31 ` Sam Steingold
2020-02-13 15:40 ` Bastien
2020-02-13 16:45 ` Sam Steingold
2020-02-14 10:02 ` Bastien
2020-02-17 4:12 ` Sam Steingold
2020-02-17 7:43 ` Bastien
2020-02-17 12:51 ` Sam Steingold
2020-02-17 13:54 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).