org-babel-insert-result doesn't comma escape properly

org-babel-insert-result doesn't comma escape properly

[Berry, Charles]

Here is an ECM:

#+begin_src emacs-lisp :wrap example
"line 1
,* headline 2
,* headline 3
,* headline 4
,* headline 5
"
#+end_src


With today's master, the last `headline' is not escaped in the example block this produces when executed.

It seems to me that dropping the let binding for `before-finish' and placing

(unless no-escape
  (org-escape-code-in-region
   beg end))

before the insertions of 'start' and 'finish' should handle this properly. And trying that on the above ECM gives the right result.

That let binding was introduced in 

commit 24a76fbe572923c55774bc9f8ecc8e6d1c7ff16d
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date:   Sun Aug 13 16:20:20 2017 +0200

I do not see why it was needed.

Best,

Chuck

Re: org-babel-insert-result doesn't comma escape properly

[Nicolas Goaziou]

Hello,

"Berry, Charles" <ccberry@ucsd.edu> writes:

> Here is an ECM:
>
> #+begin_src emacs-lisp :wrap example
> "line 1
> ,* headline 2
> ,* headline 3
> ,* headline 4
> ,* headline 5
> "
> #+end_src
>
>
> With today's master, the last `headline' is not escaped in the example
> block this produces when executed.

Indeed. Fixed.

> It seems to me that dropping the let binding for `before-finish' and placing
>
> (unless no-escape
>   (org-escape-code-in-region
>    beg end))
>
> before the insertions of 'start' and 'finish' should handle this
> properly. And trying that on the above ECM gives the right result.

But then, another regression tests fail.

> I do not see why it was needed.

I think it was to store the location of the inner part of the block.

Regards,

-- 
Nicolas Goaziou