* org-babel-insert-result doesn't comma escape properly
@ 2019-08-21 23:28 Berry, Charles
2019-08-22 17:06 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Berry, Charles @ 2019-08-21 23:28 UTC (permalink / raw)
To: Org Mode
Here is an ECM:
#+begin_src emacs-lisp :wrap example
"line 1
,* headline 2
,* headline 3
,* headline 4
,* headline 5
"
#+end_src
With today's master, the last `headline' is not escaped in the example block this produces when executed.
It seems to me that dropping the let binding for `before-finish' and placing
(unless no-escape
(org-escape-code-in-region
beg end))
before the insertions of 'start' and 'finish' should handle this properly. And trying that on the above ECM gives the right result.
That let binding was introduced in
commit 24a76fbe572923c55774bc9f8ecc8e6d1c7ff16d
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Sun Aug 13 16:20:20 2017 +0200
I do not see why it was needed.
Best,
Chuck
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: org-babel-insert-result doesn't comma escape properly
2019-08-21 23:28 org-babel-insert-result doesn't comma escape properly Berry, Charles
@ 2019-08-22 17:06 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2019-08-22 17:06 UTC (permalink / raw)
To: Berry, Charles; +Cc: Org Mode
Hello,
"Berry, Charles" <ccberry@ucsd.edu> writes:
> Here is an ECM:
>
> #+begin_src emacs-lisp :wrap example
> "line 1
> ,* headline 2
> ,* headline 3
> ,* headline 4
> ,* headline 5
> "
> #+end_src
>
>
> With today's master, the last `headline' is not escaped in the example
> block this produces when executed.
Indeed. Fixed.
> It seems to me that dropping the let binding for `before-finish' and placing
>
> (unless no-escape
> (org-escape-code-in-region
> beg end))
>
> before the insertions of 'start' and 'finish' should handle this
> properly. And trying that on the above ECM gives the right result.
But then, another regression tests fail.
> I do not see why it was needed.
I think it was to store the location of the inner part of the block.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-22 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21 23:28 org-babel-insert-result doesn't comma escape properly Berry, Charles
2019-08-22 17:06 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).