emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Berry, Charles" <ccberry@ucsd.edu>
To: Org Mode <emacs-orgmode@gnu.org>
Subject: org-babel-insert-result doesn't comma escape properly
Date: Wed, 21 Aug 2019 23:28:40 +0000	[thread overview]
Message-ID: <94FB08FE-1466-4B0A-B544-06A14E70114C@ucsd.edu> (raw)

Here is an ECM:

#+begin_src emacs-lisp :wrap example
"line 1
,* headline 2
,* headline 3
,* headline 4
,* headline 5
"
#+end_src


With today's master, the last `headline' is not escaped in the example block this produces when executed.

It seems to me that dropping the let binding for `before-finish' and placing

(unless no-escape
  (org-escape-code-in-region
   beg end))

before the insertions of 'start' and 'finish' should handle this properly. And trying that on the above ECM gives the right result.

That let binding was introduced in 

commit 24a76fbe572923c55774bc9f8ecc8e6d1c7ff16d
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date:   Sun Aug 13 16:20:20 2017 +0200

I do not see why it was needed.

Best,

Chuck

next             reply	other threads:[~2019-08-21 23:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 23:28 Berry, Charles [this message]
2019-08-22 17:06 ` org-babel-insert-result doesn't comma escape properly Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94FB08FE-1466-4B0A-B544-06A14E70114C@ucsd.edu \
    --to=ccberry@ucsd.edu \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).