Re: Replaced obsolete interactive-p function

[Eric Schulte <schulte.eric@gmail.com>]

Michael's patch looks great to me, I can confirm that it does stifle the
warnings on Emacs24, and everything compiles and works as expected -- at
least as far as the Org-mode test suite is able to differentiate.

In addition to applying this patch I've also added another patch which
supplies the optional KIND argument to every invocation of
org-called-interactively-p.

Cheers -- Eric

Carsten Dominik <carsten.dominik@gmail.com> writes:

> I suggest to talk to Eric Schulte before applying this patch....
>
> - Carsten
>
> On 30.6.2011, at 00:29, Michael Markert wrote:
>
>> On 29 Jun 2011, Bastien wrote:
>> 
>>> Dear all,
>>> 
>>> interactive-p is obsolete since Emacs 23.2 and should be replaced by
>>> called-interactively-p.
>>> 
>>> The org-called-interactively-p macro takes care of using either
>>> interactive-p or called-interactively-p.
>>> 
>>> I've just updated the latest git and Org uses
>>> org-called-interactively-p wherever it makes sense.
>>> 
>>> Please report any weird compilation warnings and/or problems.
>> 
>> I still see a lot warnings complaining about `interactive-p'.
>> I figured that it happens because the byte-compiler still sees the
>> `interactive-p's
>> 
>> Appended is a patch to the macro that checks on expand which interactive
>> predicate we need.
>> I don't see those warnings anymore and a quick check showed that it
>> behaves as the complete version (at least on emacs24).
>> 
>> Michael
>> 
>> <0001-org-macs-Determine-on-macro-expand-which-interactive.patch>
>
>

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/