From: Bastien <email@example.com>
To: Eric Schulte <firstname.lastname@example.org>
Michael Markert <email@example.com>,
Carsten Dominik <firstname.lastname@example.org>
Subject: Re: Replaced obsolete interactive-p function
Date: Thu, 30 Jun 2011 10:36:17 +0200 [thread overview]
Message-ID: <email@example.com> (raw)
In-Reply-To: <firstname.lastname@example.org> (Eric Schulte's message of "Wed, 29 Jun 2011 16:27:17 -0700")
Hi Eric and Michael,
Eric Schulte <email@example.com> writes:
> Michael's patch looks great to me, I can confirm that it does stifle the
> warnings on Emacs24, and everything compiles and works as expected -- at
> least as far as the Org-mode test suite is able to differentiate.
Thanks to Michael for the patch, it does indeed fix the warnings.
> In addition to applying this patch I've also added another patch which
> supplies the optional KIND argument to every invocation of
I thought the absence of argument was taken care by the
org-called-interactively-p macro -- see the (with-no-warning ...)
sexp in it, and the comment.
Eric, any reason for explicitely adding an argument?
I understand it's better for readability and it will ease the future
replacement of org-called-interactively-p by called-interactively-p,
but I was just curious to know if there was some other reasons.
next prev parent reply other threads:[~2011-06-30 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 16:26 Bastien
2011-06-29 22:29 ` Michael Markert
2011-06-29 22:50 ` Carsten Dominik
2011-06-29 23:27 ` Eric Schulte
2011-06-30 8:36 ` Bastien [this message]
2011-06-30 18:12 ` Eric Schulte
2011-07-01 8:59 ` Bastien
2011-06-30 9:16 ` Bastien
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).