From: Carsten Dominik <carsten.dominik@gmail.com>
To: Michael Markert <markert.michael@googlemail.com>
Cc: Bastien <bzg@altern.org>, emacs-orgmode@gnu.org
Subject: Re: Replaced obsolete interactive-p function
Date: Thu, 30 Jun 2011 00:50:04 +0200 [thread overview]
Message-ID: <FED5AF96-20E9-46B2-945B-E0366E11212F@gmail.com> (raw)
In-Reply-To: <877h845l18.wl%markert.michael@googlemail.com>
I suggest to talk to Eric Schulte before applying this patch....
- Carsten
On 30.6.2011, at 00:29, Michael Markert wrote:
> On 29 Jun 2011, Bastien wrote:
>
>> Dear all,
>>
>> interactive-p is obsolete since Emacs 23.2 and should be replaced by
>> called-interactively-p.
>>
>> The org-called-interactively-p macro takes care of using either
>> interactive-p or called-interactively-p.
>>
>> I've just updated the latest git and Org uses
>> org-called-interactively-p wherever it makes sense.
>>
>> Please report any weird compilation warnings and/or problems.
>
> I still see a lot warnings complaining about `interactive-p'.
> I figured that it happens because the byte-compiler still sees the
> `interactive-p's
>
> Appended is a patch to the macro that checks on expand which interactive
> predicate we need.
> I don't see those warnings anymore and a quick check showed that it
> behaves as the complete version (at least on emacs24).
>
> Michael
>
> <0001-org-macs-Determine-on-macro-expand-which-interactive.patch>
next prev parent reply other threads:[~2011-06-29 22:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 16:26 Replaced obsolete interactive-p function Bastien
2011-06-29 22:29 ` Michael Markert
2011-06-29 22:50 ` Carsten Dominik [this message]
2011-06-29 23:27 ` Eric Schulte
2011-06-30 8:36 ` Bastien
2011-06-30 18:12 ` Eric Schulte
2011-07-01 8:59 ` Bastien
2011-06-30 9:16 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FED5AF96-20E9-46B2-945B-E0366E11212F@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
--cc=markert.michael@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).