From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Replaced obsolete interactive-p function Date: Thu, 30 Jun 2011 00:50:04 +0200 Message-ID: References: <87zkl01u4y.fsf@gnu.org> <877h845l18.wl%markert.michael@googlemail.com> Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([140.186.70.92]:47249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qc3aE-0004Eu-Mw for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 18:50:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qc3aD-0006K5-L5 for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 18:50:10 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:42422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qc3aD-0006JZ-B6 for emacs-orgmode@gnu.org; Wed, 29 Jun 2011 18:50:09 -0400 Received: by eyd9 with SMTP id 9so657337eyd.0 for ; Wed, 29 Jun 2011 15:50:08 -0700 (PDT) In-Reply-To: <877h845l18.wl%markert.michael@googlemail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Michael Markert Cc: Bastien , emacs-orgmode@gnu.org I suggest to talk to Eric Schulte before applying this patch.... - Carsten On 30.6.2011, at 00:29, Michael Markert wrote: > On 29 Jun 2011, Bastien wrote: > >> Dear all, >> >> interactive-p is obsolete since Emacs 23.2 and should be replaced by >> called-interactively-p. >> >> The org-called-interactively-p macro takes care of using either >> interactive-p or called-interactively-p. >> >> I've just updated the latest git and Org uses >> org-called-interactively-p wherever it makes sense. >> >> Please report any weird compilation warnings and/or problems. > > I still see a lot warnings complaining about `interactive-p'. > I figured that it happens because the byte-compiler still sees the > `interactive-p's > > Appended is a patch to the macro that checks on expand which interactive > predicate we need. > I don't see those warnings anymore and a quick check showed that it > behaves as the complete version (at least on emacs24). > > Michael > > <0001-org-macs-Determine-on-macro-expand-which-interactive.patch>