* Bug in org-mobile-get-outline-path-link
@ 2017-04-06 1:45 Ian Dunn
2017-04-07 16:12 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Ian Dunn @ 2017-04-06 1:45 UTC (permalink / raw)
To: emacs-orgmode
I recently tried turning off 'org-mobile-force-id-on-agenda-items', only
to find that there were problems updating agenda tasks. I poked around
in the code and found that 'org-mobile-locate-entry' looks for an OLP in
the form olp:file:/path/to/heading, and
'org-mobile-get-outline-path-link' stores it as
olp:file/path/to/heading.
I've attached a patch to fix the latter function.
--
Ian Dunn
diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index f6ef18f10..12e6c84b3 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -648,7 +648,7 @@ The table of checksums is written to the file mobile-checksums."
(org-with-point-at pom
(concat "olp:"
(org-mobile-escape-olp (file-name-nondirectory buffer-file-name))
- "/"
+ ":"
(mapconcat 'org-mobile-escape-olp
(org-get-outline-path)
"/")
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: Bug in org-mobile-get-outline-path-link
2017-04-06 1:45 Bug in org-mobile-get-outline-path-link Ian Dunn
@ 2017-04-07 16:12 ` Nicolas Goaziou
2017-04-07 22:58 ` [PATCH] Fix bug in mobile outline path handling Ian Dunn
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2017-04-07 16:12 UTC (permalink / raw)
To: Ian Dunn; +Cc: emacs-orgmode
Hello,
Ian Dunn <dunni@gnu.org> writes:
> I recently tried turning off 'org-mobile-force-id-on-agenda-items', only
> to find that there were problems updating agenda tasks. I poked around
> in the code and found that 'org-mobile-locate-entry' looks for an OLP in
> the form olp:file:/path/to/heading, and
> 'org-mobile-get-outline-path-link' stores it as
> olp:file/path/to/heading.
>
> I've attached a patch to fix the latter function.
>
> --
> Ian Dunn
>
> diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
> index f6ef18f10..12e6c84b3 100644
> --- a/lisp/org-mobile.el
> +++ b/lisp/org-mobile.el
> @@ -648,7 +648,7 @@ The table of checksums is written to the file mobile-checksums."
> (org-with-point-at pom
> (concat "olp:"
> (org-mobile-escape-olp (file-name-nondirectory buffer-file-name))
> - "/"
> + ":"
> (mapconcat 'org-mobile-escape-olp
> (org-get-outline-path)
> "/")
It looks good. Could you provide the same patch using git format-patch,
along with a proper commit message?
Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Fix bug in mobile outline path handling
2017-04-07 16:12 ` Nicolas Goaziou
@ 2017-04-07 22:58 ` Ian Dunn
2017-04-10 19:17 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Ian Dunn @ 2017-04-07 22:58 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
* org-mobile.el (org-mobile-get-outline-path-link): Use a `:' after file instead of a `/'
---
lisp/org-mobile.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index f6ef18f10..12e6c84b3 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -648,7 +648,7 @@ The table of checksums is written to the file mobile-checksums."
(org-with-point-at pom
(concat "olp:"
(org-mobile-escape-olp (file-name-nondirectory buffer-file-name))
- "/"
+ ":"
(mapconcat 'org-mobile-escape-olp
(org-get-outline-path)
"/")
--
2.12.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix bug in mobile outline path handling
2017-04-07 22:58 ` [PATCH] Fix bug in mobile outline path handling Ian Dunn
@ 2017-04-10 19:17 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2017-04-10 19:17 UTC (permalink / raw)
To: Ian Dunn; +Cc: emacs-orgmode
Hello,
Ian Dunn <dunni@gnu.org> writes:
> * org-mobile.el (org-mobile-get-outline-path-link): Use a `:' after
> file instead of a `/'
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-10 19:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-06 1:45 Bug in org-mobile-get-outline-path-link Ian Dunn
2017-04-07 16:12 ` Nicolas Goaziou
2017-04-07 22:58 ` [PATCH] Fix bug in mobile outline path handling Ian Dunn
2017-04-10 19:17 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).