From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Bug in org-mobile-get-outline-path-link
Date: Fri, 07 Apr 2017 18:12:40 +0200
Message-ID: <87h920yz5z.fsf@nicolasgoaziou.fr>
References: <87pogq8g23.fsf@escafil>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37756)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1cwWVH-0004CI-MX
	for emacs-orgmode@gnu.org; Fri, 07 Apr 2017 12:12:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1cwWVG-00034L-SO
	for emacs-orgmode@gnu.org; Fri, 07 Apr 2017 12:12:51 -0400
In-Reply-To: <87pogq8g23.fsf@escafil> (Ian Dunn's message of "Wed, 05 Apr 2017
	21:45:24 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Ian Dunn <dunni@gnu.org>
Cc: emacs-orgmode@gnu.org

Hello,

Ian Dunn <dunni@gnu.org> writes:

> I recently tried turning off 'org-mobile-force-id-on-agenda-items', only
> to find that there were problems updating agenda tasks.  I poked around
> in the code and found that 'org-mobile-locate-entry' looks for an OLP in
> the form olp:file:/path/to/heading, and
> 'org-mobile-get-outline-path-link' stores it as
> olp:file/path/to/heading.
>
> I've attached a patch to fix the latter function.
>
> --
> Ian Dunn
>
> diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
> index f6ef18f10..12e6c84b3 100644
> --- a/lisp/org-mobile.el
> +++ b/lisp/org-mobile.el
> @@ -648,7 +648,7 @@ The table of checksums is written to the file mobile-checksums."
>    (org-with-point-at pom
>      (concat "olp:"
>  	    (org-mobile-escape-olp (file-name-nondirectory buffer-file-name))
> -	    "/"
> +	    ":"
>  	    (mapconcat 'org-mobile-escape-olp
>  		       (org-get-outline-path)
>  		       "/")

It looks good. Could you provide the same patch using git format-patch,
along with a proper commit message?

Thank you.

Regards,

-- 
Nicolas Goaziou