From: Bernt Hansen <bernt@norang.ca>
To: Manish <mailtomanish.sharma@gmail.com>
Cc: emacs-orgmode@gnu.org, Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: [PATCH 0/2] Teach org-version to include git version information
Date: Wed, 19 Aug 2009 08:08:40 -0400 [thread overview]
Message-ID: <87prasypiv.fsf@gollum.intra.norang.ca> (raw)
In-Reply-To: <e7cdbe30908190501t29a27c3cua1c30d9661acbbc@mail.gmail.com> (Manish's message of "Wed\, 19 Aug 2009 17\:31\:10 +0530")
Manish <mailtomanish.sharma@gmail.com> writes:
> On Wed, Aug 19, 2009 at 4:54 PM, Bernt Hansen wrote:
>> Does it crash and cause an error or report the old org version as before?
>
> It just reports the version as before; no crashing or error of any sort.
Okay that's good. I don't have Emacs on windows here. If you have time
to step through the org-version function in debug and figure out where
it fails we might be able to get it working on windows too.
My guess is that determining the location of the .git directory fails so
it acts just like it's not running from a git repository.
What do you get when evaluating the following form?
(file-name-directory (locate-library "org"))
I need to move up one directory from what that returns to see if the
.git directory exists and I append '../' to the path to move up on *nix
systems. That probably doesn't work for windows. Maybe there's a
better way to strip off the last directory from the path that
file-name-directory returns.
-Bernt
next prev parent reply other threads:[~2009-08-19 12:08 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 17:22 [PATCH 0/2] Teach org-version to include git version information Bernt Hansen
2009-08-18 17:22 ` [PATCH 1/2] Add git version number to org-version information Bernt Hansen
2009-08-18 17:22 ` [PATCH 2/2] Add .dirty to git org-version info if files are modified Bernt Hansen
2009-08-18 19:08 ` [PATCH 0/2] Teach org-version to include git version information Carsten Dominik
2009-08-18 19:10 ` Bernt Hansen
2009-08-18 19:15 ` Carsten Dominik
2009-08-18 19:30 ` Stefan Vollmar
2009-08-18 19:44 ` Bernt Hansen
2009-08-18 19:48 ` Stefan Vollmar
2009-08-19 10:10 ` Manish
2009-08-19 11:24 ` Bernt Hansen
2009-08-19 12:01 ` Manish
2009-08-19 12:08 ` Bernt Hansen [this message]
2009-08-19 12:19 ` Manish
2009-08-19 12:30 ` Bernt Hansen
2009-08-19 13:20 ` Manish
2009-08-19 13:32 ` Bernt Hansen
2009-08-19 13:34 ` Bernt Hansen
2009-08-19 13:58 ` Manish
2009-08-19 14:02 ` Nick Dokos
2009-08-19 14:16 ` Manish
2009-08-19 14:29 ` Nick Dokos
2009-08-19 14:42 ` Bernt Hansen
2009-08-19 14:51 ` Manish
2009-08-19 15:04 ` Nick Dokos
2009-08-19 15:10 ` Manish
2009-08-19 15:16 ` Bernt Hansen
2009-08-19 15:23 ` Manish
2009-08-19 15:27 ` Bernt Hansen
2009-08-19 20:06 ` [PATCH 0/2] org-version fix for windows Bernt Hansen
2009-08-20 3:54 ` Bernt Hansen
2009-08-20 19:06 ` Bernt Hansen
2009-08-20 19:53 ` Carsten Dominik
2009-08-19 20:06 ` [PATCH 1/2] Use lisp cd function to change directories to avoid shell dependencies Bernt Hansen
2009-08-19 20:06 ` [PATCH 2/2] Skip git-version determination if git command fails Bernt Hansen
2009-08-19 14:17 ` [PATCH 0/2] Teach org-version to include git version information Bernt Hansen
2009-08-19 14:41 ` Manish
2009-08-19 14:44 ` Bernt Hansen
2009-08-19 13:22 ` Manish
2009-08-19 13:40 ` Bernt Hansen
2009-08-19 13:57 ` Nick Dokos
2009-08-19 12:21 ` Nick Dokos
2009-08-19 12:30 ` Manish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prasypiv.fsf@gollum.intra.norang.ca \
--to=bernt@norang.ca \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mailtomanish.sharma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).