From: Manish <mailtomanish.sharma@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH 0/2] Teach org-version to include git version information
Date: Wed, 19 Aug 2009 20:21:20 +0530 [thread overview]
Message-ID: <e7cdbe30908190751g4de47fbcu4491f6ea3e269ca1@mail.gmail.com> (raw)
In-Reply-To: <87ws4zyifb.fsf@gollum.intra.norang.ca>
On Wed, Aug 19, 2009 at 8:12 PM, Bernt Hansen wrote:
> Nick Dokos writes:
>
>> Thanks! IIUC, there are then multiple forks in the decision tree:
>>
>> o running on Windows or on something else?
>>
>> o if on Windows, running native or under cygwin?
>>
>> o what shell am I using? cmd.exe and bash under cygwin accept
>> different syntax - in particular, the GITDIR=foo solution of
>> setting env variables has no hope of working under cmd.exe -
>> is that correct?
>>
>> Sounds complicated. Maybe the best solution for now is to punt on
>> the git information on Windows?
>>
>> (when (not (member system-type '(ms-dos windows-nt cygwin)))
>> ...add git info...)
>>
>> What about system-type == "darwin"? Does Bernt's code work there?
>
> Yes it'll be complicated. Right now I think we should punt and just go
> back to the old org-version reporting for windows until we can get a
> better working solution since the current version breaks on windows.
> I'll try to provide a patch for this.
>
> Manish:
>
> What value do you have for system-type? I expect it says 'windows-nt'
Yes, it does.
>
> If that's true then the problem is determining if
> - git is installed
> - what version? Msysgit? cygwin git?
> - what shells are available (since CMD.exe has little hope of working)
> - msysgit bash
> - cygwin shell
> - cmd (won't work if msysgit was installed with git in the msysgit
> bash shell only)
> - running some other shell (git-bash, cygwin) so the git executable is
> available and provide the right syntax for each to Do The Right
> Thing(tm)
Do we test if git is installed if we are on a non-Windows system or
show whatever error shell returns in case git is not installed?
I tried calling cygwin git from CMD shell and it seems to work okay.
So I am guessing we need to figure out how to correctly pass git
command from Emacs to Windows shell. I will try to find examples from
Org's PDF processing code.
>
> Right now I'm inclined to skip the git-version magic if system-type is
> windows-nt just to stop it from breaking on that platform.
Sure. I will share some information/examples if I can find anything
to make it work.
Thanks
--
Manish>
next prev parent reply other threads:[~2009-08-19 14:51 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 17:22 [PATCH 0/2] Teach org-version to include git version information Bernt Hansen
2009-08-18 17:22 ` [PATCH 1/2] Add git version number to org-version information Bernt Hansen
2009-08-18 17:22 ` [PATCH 2/2] Add .dirty to git org-version info if files are modified Bernt Hansen
2009-08-18 19:08 ` [PATCH 0/2] Teach org-version to include git version information Carsten Dominik
2009-08-18 19:10 ` Bernt Hansen
2009-08-18 19:15 ` Carsten Dominik
2009-08-18 19:30 ` Stefan Vollmar
2009-08-18 19:44 ` Bernt Hansen
2009-08-18 19:48 ` Stefan Vollmar
2009-08-19 10:10 ` Manish
2009-08-19 11:24 ` Bernt Hansen
2009-08-19 12:01 ` Manish
2009-08-19 12:08 ` Bernt Hansen
2009-08-19 12:19 ` Manish
2009-08-19 12:30 ` Bernt Hansen
2009-08-19 13:20 ` Manish
2009-08-19 13:32 ` Bernt Hansen
2009-08-19 13:34 ` Bernt Hansen
2009-08-19 13:58 ` Manish
2009-08-19 14:02 ` Nick Dokos
2009-08-19 14:16 ` Manish
2009-08-19 14:29 ` Nick Dokos
2009-08-19 14:42 ` Bernt Hansen
2009-08-19 14:51 ` Manish [this message]
2009-08-19 15:04 ` Nick Dokos
2009-08-19 15:10 ` Manish
2009-08-19 15:16 ` Bernt Hansen
2009-08-19 15:23 ` Manish
2009-08-19 15:27 ` Bernt Hansen
2009-08-19 20:06 ` [PATCH 0/2] org-version fix for windows Bernt Hansen
2009-08-20 3:54 ` Bernt Hansen
2009-08-20 19:06 ` Bernt Hansen
2009-08-20 19:53 ` Carsten Dominik
2009-08-19 20:06 ` [PATCH 1/2] Use lisp cd function to change directories to avoid shell dependencies Bernt Hansen
2009-08-19 20:06 ` [PATCH 2/2] Skip git-version determination if git command fails Bernt Hansen
2009-08-19 14:17 ` [PATCH 0/2] Teach org-version to include git version information Bernt Hansen
2009-08-19 14:41 ` Manish
2009-08-19 14:44 ` Bernt Hansen
2009-08-19 13:22 ` Manish
2009-08-19 13:40 ` Bernt Hansen
2009-08-19 13:57 ` Nick Dokos
2009-08-19 12:21 ` Nick Dokos
2009-08-19 12:30 ` Manish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7cdbe30908190751g4de47fbcu4491f6ea3e269ca1@mail.gmail.com \
--to=mailtomanish.sharma@gmail.com \
--cc=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).