From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manish Subject: Re: [PATCH 0/2] Teach org-version to include git version information Date: Wed, 19 Aug 2009 20:21:20 +0530 Message-ID: References: <1250616163-11733-1-git-send-email-bernt@norang.ca> <87iqgkyoic.fsf@gollum.intra.norang.ca> <87eir8ylni.fsf@gollum.intra.norang.ca> <10259.1250690543@gamaville.dokosmarshall.org> <10437.1250692180@gamaville.dokosmarshall.org> <87ws4zyifb.fsf@gollum.intra.norang.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MdmVu-0002ED-Qw for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 10:51:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MdmVq-000247-A6 for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 10:51:46 -0400 Received: from [199.232.76.173] (port=38451 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MdmVq-00023s-2c for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 10:51:42 -0400 Received: from mail-yw0-f190.google.com ([209.85.211.190]:64545) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MdmVp-0005l7-Ng for emacs-orgmode@gnu.org; Wed, 19 Aug 2009 10:51:41 -0400 Received: by ywh28 with SMTP id 28so6325347ywh.27 for ; Wed, 19 Aug 2009 07:51:41 -0700 (PDT) In-Reply-To: <87ws4zyifb.fsf@gollum.intra.norang.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: emacs-orgmode@gnu.org On Wed, Aug 19, 2009 at 8:12 PM, Bernt Hansen wrote: > Nick Dokos writes: > >> Thanks! IIUC, there are then multiple forks in the decision tree: >> >> o running on Windows or on something else? >> >> o if on Windows, running native or under cygwin? >> >> o what shell am I using? cmd.exe and bash under cygwin accept >> different syntax - in particular, the GITDIR=foo solution of >> setting env variables has no hope of working under cmd.exe - >> is that correct? >> >> Sounds complicated. Maybe the best solution for now is to punt on >> the git information on Windows? >> >> (when (not (member system-type '(ms-dos windows-nt cygwin))) >> ...add git info...) >> >> What about system-type == "darwin"? Does Bernt's code work there? > > Yes it'll be complicated. Right now I think we should punt and just go > back to the old org-version reporting for windows until we can get a > better working solution since the current version breaks on windows. > I'll try to provide a patch for this. > > Manish: > > What value do you have for system-type? I expect it says 'windows-nt' Yes, it does. > > If that's true then the problem is determining if > - git is installed > - what version? Msysgit? cygwin git? > - what shells are available (since CMD.exe has little hope of working) > - msysgit bash > - cygwin shell > - cmd (won't work if msysgit was installed with git in the msysgit > bash shell only) > - running some other shell (git-bash, cygwin) so the git executable is > available and provide the right syntax for each to Do The Right > Thing(tm) Do we test if git is installed if we are on a non-Windows system or show whatever error shell returns in case git is not installed? I tried calling cygwin git from CMD shell and it seems to work okay. So I am guessing we need to figure out how to correctly pass git command from Emacs to Windows shell. I will try to find examples from Org's PDF processing code. > > Right now I'm inclined to skip the git-version magic if system-type is > windows-nt just to stop it from breaking on that platform. Sure. I will share some information/examples if I can find anything to make it work. Thanks -- Manish>