emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-icalendar: fix handling of timestamps
Date: Thu, 15 Aug 2013 09:55:41 +0200	[thread overview]
Message-ID: <87ob8z8k1u.fsf@gmail.com> (raw)
In-Reply-To: <20130811125354.GB69042@kenny.local> (Viktor Rosenfeld's message of "Sun, 11 Aug 2013 14:53:54 +0200")

Viktor Rosenfeld <listuser36@gmail.com> writes:

Thanks for the patch. A small comment follows:

> +		   (let ((type (org-element-property :type ts))
> +			 (uid (format "TS%d-%s" (incf counter) uid)))
> +		     (when (or (eq with-timestamps t)
> +			       (and (eq with-timestamps 'active)
> +				    (memq type '(active active-range)))
> +			       (and (eq with-timestamps 'inactive)
> +				    (memq type '(inactive 'inactive-range))))
> +		       (org-icalendar--vevent entry ts uid summary loc desc cat))))

This is not correct since COUNTER is increased before we know if the
VEVENT will be created. IOW, (let ((uid ...))) should be moved after the
`when'.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2013-08-15  7:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-11  2:03 [PATCH] ox-icalendar: fix handling of timestamps Viktor Rosenfeld
2013-08-11  2:13 ` Aaron Ecay
2013-08-11 12:53   ` Viktor Rosenfeld
2013-08-15  7:55     ` Nicolas Goaziou [this message]
2013-08-11  7:30 ` Nicolas Goaziou
2013-08-11 12:42   ` Viktor Rosenfeld
2013-08-11 13:15     ` Nicolas Goaziou
2013-08-11 14:14       ` Viktor Rosenfeld
2013-08-11 15:09         ` Viktor Rosenfeld
2013-08-15  7:52           ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ob8z8k1u.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).