emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-icalendar: fix handling of timestamps
Date: Sun, 11 Aug 2013 09:30:11 +0200	[thread overview]
Message-ID: <87mwooznuk.fsf@gmail.com> (raw)
In-Reply-To: <20130811020358.GA30350@kenny.local> (Viktor Rosenfeld's message of "Sun, 11 Aug 2013 04:03:59 +0200")

Hello,

Viktor Rosenfeld <listuser36@gmail.com> writes:

>   * ox-icalendar.el (org-icalendar-entry): Honor setting of
>   `org-icalendar-with-timestamps' for timestamps on headlines
>   and checkboxes.
>
>   The setting `org-icalendar-with-timestamps' was only applied
>   to timestamps which do not appear on a heading or on a
>   checkbox. E.g., with `org-icalendar-with-timestamps' set to
>   'active, an heading containing an inactive timestamp on would
>   be exported. This patch fixes this.

This would make icalendar back-end inconsistent with other back-ends,
see `org-export-with-timestamps' docstring.

If inconsistency is desirable in this case, `org-icalendar-with-timestamps'
docstring should clearly state it.


Regards,

-- 
Nicolas Goaziou

  parent reply	other threads:[~2013-08-11  7:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-11  2:03 [PATCH] ox-icalendar: fix handling of timestamps Viktor Rosenfeld
2013-08-11  2:13 ` Aaron Ecay
2013-08-11 12:53   ` Viktor Rosenfeld
2013-08-15  7:55     ` Nicolas Goaziou
2013-08-11  7:30 ` Nicolas Goaziou [this message]
2013-08-11 12:42   ` Viktor Rosenfeld
2013-08-11 13:15     ` Nicolas Goaziou
2013-08-11 14:14       ` Viktor Rosenfeld
2013-08-11 15:09         ` Viktor Rosenfeld
2013-08-15  7:52           ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwooznuk.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).