From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [PATCH] ox-icalendar: fix handling of timestamps
Date: Sun, 11 Aug 2013 09:30:11 +0200
Message-ID: <87mwooznuk.fsf@gmail.com>
References: <20130811020358.GA30350@kenny.local>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44035)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1V8Q6J-00022U-Vc
	for emacs-orgmode@gnu.org; Sun, 11 Aug 2013 03:30:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1V8Q6B-0006Wm-IT
	for emacs-orgmode@gnu.org; Sun, 11 Aug 2013 03:30:07 -0400
Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:60050)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1V8Q6B-0006WU-CY
	for emacs-orgmode@gnu.org; Sun, 11 Aug 2013 03:29:59 -0400
Received: by mail-ee0-f48.google.com with SMTP id l10so2830724eei.21
	for <emacs-orgmode@gnu.org>; Sun, 11 Aug 2013 00:29:58 -0700 (PDT)
Received: from selenimh ([91.224.148.150])
	by mx.google.com with ESMTPSA id c3sm45723129eev.3.2013.08.11.00.29.57
	for <emacs-orgmode@gnu.org>
	(version=TLSv1.2 cipher=RC4-SHA bits=128/128);
	Sun, 11 Aug 2013 00:29:58 -0700 (PDT)
In-Reply-To: <20130811020358.GA30350@kenny.local> (Viktor Rosenfeld's message
	of "Sun, 11 Aug 2013 04:03:59 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Hello,

Viktor Rosenfeld <listuser36@gmail.com> writes:

>   * ox-icalendar.el (org-icalendar-entry): Honor setting of
>   `org-icalendar-with-timestamps' for timestamps on headlines
>   and checkboxes.
>
>   The setting `org-icalendar-with-timestamps' was only applied
>   to timestamps which do not appear on a heading or on a
>   checkbox. E.g., with `org-icalendar-with-timestamps' set to
>   'active, an heading containing an inactive timestamp on would
>   be exported. This patch fixes this.

This would make icalendar back-end inconsistent with other back-ends,
see `org-export-with-timestamps' docstring.

If inconsistency is desirable in this case, `org-icalendar-with-timestamps'
docstring should clearly state it.


Regards,

-- 
Nicolas Goaziou