From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [PATCH] ox-icalendar: fix handling of timestamps
Date: Thu, 15 Aug 2013 09:55:41 +0200
Message-ID: <87ob8z8k1u.fsf@gmail.com>
References: <20130811020358.GA30350@kenny.local> <87ob95dlel.fsf@gmail.com>
	<20130811125354.GB69042@kenny.local>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55415)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1V9sPC-0007dA-Eq
	for emacs-orgmode@gnu.org; Thu, 15 Aug 2013 03:55:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1V9sP3-00053K-SY
	for emacs-orgmode@gnu.org; Thu, 15 Aug 2013 03:55:38 -0400
Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:62245)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1V9sP3-000535-MU
	for emacs-orgmode@gnu.org; Thu, 15 Aug 2013 03:55:29 -0400
Received: by mail-wi0-f178.google.com with SMTP id j17so2830240wiw.5
	for <emacs-orgmode@gnu.org>; Thu, 15 Aug 2013 00:55:28 -0700 (PDT)
In-Reply-To: <20130811125354.GB69042@kenny.local> (Viktor Rosenfeld's message
	of "Sun, 11 Aug 2013 14:53:54 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Viktor Rosenfeld <listuser36@gmail.com> writes:

Thanks for the patch. A small comment follows:

> +		   (let ((type (org-element-property :type ts))
> +			 (uid (format "TS%d-%s" (incf counter) uid)))
> +		     (when (or (eq with-timestamps t)
> +			       (and (eq with-timestamps 'active)
> +				    (memq type '(active active-range)))
> +			       (and (eq with-timestamps 'inactive)
> +				    (memq type '(inactive 'inactive-range))))
> +		       (org-icalendar--vevent entry ts uid summary loc desc cat))))

This is not correct since COUNTER is increased before we know if the
VEVENT will be created. IOW, (let ((uid ...))) should be moved after the
`when'.


Regards,

-- 
Nicolas Goaziou